generate different sql code based on dialect #6915
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| formatSelectClause: defaultFormatter.formatSelectClause, | ||
| }, | ||
| default: defaultFormatter, | ||
| }; |
There was a problem hiding this comment.
i wonder if we can instead use guessDialect and the information from there for quoting
There was a problem hiding this comment.
thanks for this, it only works for bigquery as some dialects from codemirror don't have identifierQuotes.
| } | ||
|
|
||
| return `_df = mo.sql(f"SELECT ${columnName} FROM ${tableName} LIMIT 100", engine=${engine})`; | ||
| return `_df = mo.sql(f"""${selectClause}""", engine=${engine})`; |
There was a problem hiding this comment.
maybe new lines around the query in case it ends with a "
| switch (connection.dialect) { | ||
| ): SQLDialect { | ||
| const dialect = connection.dialect; | ||
| if (!isKnownDialect(dialect)) { |
There was a problem hiding this comment.
would it better to just fall though the switch-case so this does not get out of sync?
I can add a logNever and force us to return something. The reason to return early is to ensure the dialect is type-safe, so we must catch that dialect in the switch statements. It will throw error if spelling is off etc. |
📝 Summary
Fixes #6875. Might also tackle #6872.
🔍 Description of Changes
📋 Checklist