Skip to content

add run stale cells tool, refactor out notebook actions #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2025
Merged

add run stale cells tool, refactor out notebook actions #6842

merged 6 commits into from
Oct 22, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Oct 20, 2025 •
edited
Loading

📝 Summary

Adds a run stale cells tool, which returns console output & cell output, reusing code from Cell context provider.

CleanShot.2025-10-21.at.22.18.27.mp4

Todo:

@bjoaquinc if you want to have a look, but no expectation that you need to review

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Oct 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 22, 2025 2:25am

Light2Dark
Light2Dark commented Oct 21, 2025
View reviewed changes
@Light2Dark Light2Dark marked this pull request as ready for review October 21, 2025 14:20
@Light2Dark Light2Dark requested a review from manzt as a code owner October 21, 2025 14:20
@Light2Dark Light2Dark marked this pull request as draft October 21, 2025 14:25
@Light2Dark Light2Dark marked this pull request as ready for review October 21, 2025 15:24
mscolnick
mscolnick previously approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice sick!

mscolnick
mscolnick reviewed Oct 21, 2025
View reviewed changes
frontend/src/core/ai/tools/registry.ts Outdated
export const FRONTEND_TOOL_REGISTRY = new FrontendToolRegistry([
new EditNotebookTool(store),
// ADD MORE TOOLS HERE
new RunStaleCellsTool(store),
Copy link
Contributor

@mscolnick mscolnick Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is store still needed?

Copy link
Contributor Author

@Light2Dark Light2Dark Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved it tool context, thank you!

@Light2Dark Light2Dark merged commit a208c5d into main Oct 22, 2025
26 checks passed
@Light2Dark Light2Dark deleted the sham/run-stale-cells-tool branch October 22, 2025 02:58
@dmadisetti dmadisetti added the enhancement New feature or request label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

@manzt manzt Awaiting requested review from manzt manzt is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Light2Dark @mscolnick @dmadisetti