Skip to content

Conversation

@manzt
Copy link
Contributor

@manzt manzt commented Jul 19, 2025

#5457 addressed multiple visible cursors with Vim bindings using the last focused editor, but modal editing #5614 introduced new states we didn't account for. This lead to awkward multiple cursors states based on where command mode was entered and exited.

This PR ensures vim block cursors are hidden entirely while in command mode, deferring to blue ring as the indicator of "selected". I find it much less distracting.

Before

After

@manzt manzt requested a review from Light2Dark as a code owner July 19, 2025 22:01
@vercel
Copy link

vercel bot commented Jul 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2025 10:14pm

@manzt manzt added the bug Something isn't working label Jul 19, 2025
@manzt manzt added the includes-media Description includes multimedia provided to illustrate functionality. label Jul 19, 2025
517e6d3 addressed multiple visible cursors with Vim bindings using the
last focused editor, but modal editing introduced new states we didn't
account for. These changes ensure the vim block is hidden entirely while
in command mode.
@manzt manzt merged commit defc7c6 into main Jul 19, 2025
24 of 25 checks passed
@manzt manzt deleted the fix-vim-cursors-command-mode branch July 19, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working includes-media Description includes multimedia provided to illustrate functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants