fix: query parameters in ws #5381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
akshayka
commented
Jun 20, 2025
| } | ||
| } | ||
|
|
||
| // Move over window level parameters to the WebSocket URL |
There was a problem hiding this comment.
@dmadisetti Was there a reason for stripping unknown query parameters? This breaks mo.query_params().
Was this code too aggressively refactored, i.e. is there a codepath that relies on query parameter stripping?
There was a problem hiding this comment.
A little too conservative - with the refactor query params were not passed down at all. Thanks for the general fix
…rimo into aka/fix-query-param-in-ws
akshayka
commented
Jun 20, 2025
Comment on lines
+60
to
65
| if ( | ||
| restrictToKnownQueryParams && | ||
| !Object.values(KnownQueryParams).includes(key) | ||
| ) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I included this in case other code paths do need to restrict to known query parameters.
There was a problem hiding this comment.
Got it, so just don't filter known query params, pass all through?
Edit: nvm, saw your approval.
dmadisetti
approved these changes
Jun 21, 2025
akshayka
added a commit
that referenced
this pull request
Jun 21, 2025
This fixes a regression that caused `mo.query_params()` to stop working. We need to send all query parameters to the backend, not just known ones, as part of the websocket URL. Tested by playing with the query parameters smoke test (`_marimo/smoke_tests`). Fixes #5376. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jun 28, 2025
This fixes a regression that caused `mo.query_params()` to stop working. We need to send all query parameters to the backend, not just known ones, as part of the websocket URL. Tested by playing with the query parameters smoke test (`_marimo/smoke_tests`). Fixes marimo-team#5376. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 7, 2025
This fixes a regression that caused `mo.query_params()` to stop working. We need to send all query parameters to the backend, not just known ones, as part of the websocket URL. Tested by playing with the query parameters smoke test (`_marimo/smoke_tests`). Fixes marimo-team#5376. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that caused
mo.query_params()to stop working. We need to send all query parameters to the backend, not just known ones, as part of the websocket URL.Tested by playing with the query parameters smoke test (
_marimo/smoke_tests).Fixes #5376.