feat: add footer for chat-panel chat input and change settings button #5354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…models, and a send button
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Jun 19, 2025
| PlusIcon, | ||
| SendIcon, | ||
| Settings, | ||
| Square, |
There was a problem hiding this comment.
super nit: i try to add *Icon instead (e.g. SquareIcon) because they always conflict with other components
mscolnick
reviewed
Jun 19, 2025
| icon={<BotMessageSquareIcon />} | ||
| /> | ||
| )} | ||
| {chats.map((chat) => ( |
There was a problem hiding this comment.
maybe its fixed now, but last i opened this, the chat item in the history did not extend the full width. just wanted to callout in case you saw the same
There was a problem hiding this comment.
Yeah I noticed that after one of your previous commits the chat history got wider
Is this what you were referring to?
There was a problem hiding this comment.
yea exactly. it would be nice to be a single column list (and not centered). im not sure what happened.
There was a problem hiding this comment.
feel free to design as you see fit too
There was a problem hiding this comment.
Alright so i changed the following:
- Ordered the chats from newest - oldest rather than oldest - newest
- Made each chat full width and aligned left
- Updated the title creation to only add ... if the first message is cut short, also increased the characters from 30 to 50 to fill up the new width better
Light2Dark
reviewed
Jun 19, 2025
| </SelectContent> | ||
| </Select> */} | ||
| <Select value={currentModel} onValueChange={handleModelChange}> | ||
| <SelectTrigger className="h-6 text-xs border-0 bg-transparent hover:bg-muted/30 focus:ring-0 focus:shadow-none py-0 px-2 gap-1"> |
There was a problem hiding this comment.
suggestion to make it clearer h-6 text-xs border-border !shadow-none !ring-0 bg-muted
There was a problem hiding this comment.
Way better! thanks. Especially this: !shadow-none
mscolnick
approved these changes
Jun 19, 2025
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jun 28, 2025
…marimo-team#5354) ## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes marimo-team#123). --> Added a footer with mode and model dropdowns. Updated the Settings button to an icon on the right side <img width="434" alt="Screenshot 2025-06-19 at 1 11 14 AM" src="https://github.com/user-attachments/assets/2ca46d04-98eb-4173-a4c5-f1e2235624d9" /> ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> - Added footer in chat input (see image): - Added mode dropdown with two options: **ask** and **manual** (Commented out until we add tools for ask mode) - Added a model dropdown for easy updating and visibility - Added send button that also functions as stop button while the LLM is generating text - Changed the ai settings button to an icon on the right side (see image) Next PR: Set up /tool endpoint and call it from the onToolCall() function in chat-panel.tsx ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers <!-- Tag potential reviewers from the community or maintainers who might be interested in reviewing this pull request. Your PR will be reviewed more quickly if you can figure out the right person to tag with @ --> @mscolnick
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 7, 2025
…marimo-team#5354) ## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes marimo-team#123). --> Added a footer with mode and model dropdowns. Updated the Settings button to an icon on the right side <img width="434" alt="Screenshot 2025-06-19 at 1 11 14 AM" src="https://github.com/user-attachments/assets/2ca46d04-98eb-4173-a4c5-f1e2235624d9" /> ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> - Added footer in chat input (see image): - Added mode dropdown with two options: **ask** and **manual** (Commented out until we add tools for ask mode) - Added a model dropdown for easy updating and visibility - Added send button that also functions as stop button while the LLM is generating text - Changed the ai settings button to an icon on the right side (see image) Next PR: Set up /tool endpoint and call it from the onToolCall() function in chat-panel.tsx ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers <!-- Tag potential reviewers from the community or maintainers who might be interested in reviewing this pull request. Your PR will be reviewed more quickly if you can figure out the right person to tag with @ --> @mscolnick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Added a footer with mode and model dropdowns. Updated the Settings button to an icon on the right side
🔍 Description of Changes
Next PR: Set up /tool endpoint and call it from the onToolCall() function in chat-panel.tsx
📋 Checklist
📜 Reviewers
@mscolnick