improvement: support uploading folders in the sidebar (keep heirarchy) #5349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR aims to enhance the file explorer sidebar by enabling folder uploads that retain the original hierarchy and by introducing a PDF viewer for file previewing.
- Introduced logic in the upload module to extract and use folder paths from file inputs.
- Added a PdfViewer component and integrated it into the file viewer.
- Updated media detection logic to include PDF files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/components/editor/file-tree/upload.tsx | Added logic for folder upload and functions to process file paths. |
| frontend/src/components/editor/file-tree/renderers.tsx | Added a new PdfViewer component. |
| frontend/src/components/editor/file-tree/file-viewer.tsx | Integrated PdfViewer and updated media handling for PDFs. |
Comments suppressed due to low confidence (1)
frontend/src/components/editor/file-tree/upload.tsx:48
- Method name 'guessDeliminator' might be a typo; consider renaming it to 'guessDelimiter' to improve clarity.
directoryPath = PathBuilder.guessDeliminator(filePath).dirname(
manzt
previously approved these changes
Jun 19, 2025
Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com>
for more information, see https://pre-commit.ci
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jun 28, 2025
marimo-team#5349) This allows you to upload the folder with items and will keep the same folder structure. This also adds a PDF viewer to the file explorer sidebar --------- Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 7, 2025
marimo-team#5349) This allows you to upload the folder with items and will keep the same folder structure. This also adds a PDF viewer to the file explorer sidebar --------- Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to upload the folder with items and will keep the same folder structure.
This also adds a PDF viewer to the file explorer sidebar