fix: centering/aligning of file-button by removing flex-grow #5266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the flex-grow utility from the file-upload button container to correct its centering and alignment.
- Removed
flex-growfrom the container’s Tailwind classes. - Aims to prevent the button from expanding and ensure proper layout.
Comments suppressed due to low confidence (1)
frontend/src/plugins/impl/FileUploadPlugin.tsx:187
- This layout change affects the component's visual presentation but isn't covered by tests; consider adding or updating a visual regression or snapshot test to verify the button's alignment.
<div className="flex flex-row items-center justify-start gap-2">
Light2Dark
approved these changes
Jun 11, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.16-dev72 |
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jun 28, 2025
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5265