Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Jun 10, 2025

📝 Summary

There is opportunity to cleanup a few things:

  • don't need to use Context.Provider
  • don't need to use forwardRef, can pass refs as props

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@vercel
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 2:21pm

@mscolnick
Copy link
Contributor

mscolnick commented Jun 10, 2025

There are some places to migrate:

const ReactCompilerConfig = {
-  target: "18",
+  target: "19",
};

@Light2Dark Light2Dark marked this pull request as ready for review June 11, 2025 03:59
@mscolnick mscolnick merged commit c7e4469 into main Jun 11, 2025
23 of 24 checks passed
@mscolnick mscolnick deleted the sham/upgrade-react-19 branch June 11, 2025 12:30
@github-actions
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.16-dev69

sebbeutler pushed a commit to sebbeutler/marimo that referenced this pull request Jun 28, 2025
sebbeutler pushed a commit to sebbeutler/marimo that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants