Minor correction in fileformat.py #5149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marimo generates `value=say_hello()`, not `value="Hello, World!"` for "cell three" in the example.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
akshayka
approved these changes
May 31, 2025
|
Thanks for the PR and for the kind words! |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.16-dev13 |
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jun 28, 2025
marimo generates `value=say_hello()`, not `value="Hello, World!"` for "cell three" in the example. ## 📝 Summary Hi, trying out marimo for the first time today- what a gorgeous experience, props to the whole team behind this. I was following the tutorial and noticed a minor mistake in the [fileformat tutorial](https://github.com/marimo-team/marimo/blob/main/marimo/_tutorials/fileformat.py) - line 97 in the markdown cell about the file generated by marimo suggests it would contain ```python text = mo.ui.text(value="Hello, World!") ``` ## 🔍 Description of Changes However, this line should be ```python text = mo.ui.text(value=say_hello()) ``` I've updated the `fileformat.py` tutorial accordingly. This does not effect the functionality of the tutorial, only the accuracy. Cheers, Matt ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. - [x] I have read the CLA Document and I hereby sign the CLA. ## 📜 Reviewers @akshayka OR @mscolnick
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 7, 2025
marimo generates `value=say_hello()`, not `value="Hello, World!"` for "cell three" in the example. ## 📝 Summary Hi, trying out marimo for the first time today- what a gorgeous experience, props to the whole team behind this. I was following the tutorial and noticed a minor mistake in the [fileformat tutorial](https://github.com/marimo-team/marimo/blob/main/marimo/_tutorials/fileformat.py) - line 97 in the markdown cell about the file generated by marimo suggests it would contain ```python text = mo.ui.text(value="Hello, World!") ``` ## 🔍 Description of Changes However, this line should be ```python text = mo.ui.text(value=say_hello()) ``` I've updated the `fileformat.py` tutorial accordingly. This does not effect the functionality of the tutorial, only the accuracy. Cheers, Matt ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. - [x] I have read the CLA Document and I hereby sign the CLA. ## 📜 Reviewers @akshayka OR @mscolnick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marimo generates
value=say_hello(), notvalue="Hello, World!"for "cell three" in the example.📝 Summary
Hi, trying out marimo for the first time today- what a gorgeous experience, props to the whole team behind this.
I was following the tutorial and noticed a minor mistake in the fileformat tutorial - line 97 in the markdown cell about the file generated by marimo suggests it would contain
🔍 Description of Changes
However, this line should be
I've updated the
fileformat.pytutorial accordingly.This does not effect the functionality of the tutorial, only the accuracy.
Cheers, Matt
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick