chore: cleanup config passing to HTML from server #5120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks good at first glance and I see the utility of being able to pass this down. Is it just filename that's left? AFK but my thought is to:
|
|
Looks good at a high level. Noticed the backward compatibility, nice. Some tests failing, haven't kicked the tires, but looks good otherwise |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.16-dev4 |
manzt
added a commit
that referenced
this pull request
Jun 27, 2025
The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
manzt
added a commit
that referenced
this pull request
Jun 27, 2025
The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
manzt
added a commit
that referenced
this pull request
Jun 27, 2025
The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
manzt
added a commit
that referenced
this pull request
Jun 28, 2025
The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
manzt
added a commit
that referenced
this pull request
Jun 28, 2025
The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
manzt
added a commit
that referenced
this pull request
Jun 28, 2025
The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
akshayka
pushed a commit
that referenced
this pull request
Jun 28, 2025
Fixes #5428 The changes in #5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 7, 2025
…o-team#5480) Fixes marimo-team#5428 The changes in marimo-team#5120 removed passing configuration data via HTML DOM elements. However, the marimo VS Code extension depends on these DOM-based attributes, leading to a regression. These changes restore the minimal set of DOM data attributes (`marimo-version`, `marimo-user-config`, `marimo-server-token`) required by the extension to function correctly. These additions are marked as temporary and should be removed once the extension is updated to no longer rely on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start of removing some of the complexity taken on by passing config via HTML dom elements. This also paves the way to clean up some global state that has leaked over time.
There are some DOM elements still left around, but will handle those in a followup