Skip to content

Conversation

@Haleshot
Copy link
Contributor

@Haleshot Haleshot commented May 23, 2025

📝 Summary

Fix failing data_explorer preview in docs by removing duplicate import statement

Screenshot

image

🔍 Description of Changes

Our /// marimo-embed previews already add the import marimo as mo block by default? The module was imported again in the data_explorer preview page in the second example.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

@Haleshot Haleshot changed the title chore: remove duplicate import in data_explorer documentation chore: remove duplicate import in data_explorer docs May 23, 2025
@vercel
Copy link

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 2:52pm

mscolnick
mscolnick previously approved these changes May 23, 2025
@mscolnick
Copy link
Contributor

sorry @Haleshot i reverted the previous PR that created this, but it was breaking main

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 8, 2025
@mscolnick mscolnick merged commit a557111 into marimo-team:main Jul 8, 2025
21 of 25 checks passed
sebbeutler pushed a commit to sebbeutler/marimo that referenced this pull request Jul 16, 2025
)

## 📝 Summary

Fix failing `data_explorer` preview in docs by removing duplicate import
statement

<details>

<summary> Screenshot </summary>


![image](https://github.com/user-attachments/assets/bfc0efcd-69ca-4abc-9cc2-a39cf054c8e1)

</details>

## 🔍 Description of Changes

Our `/// marimo-embed` previews already add the `import marimo as mo`
block by default? The module was imported again in the data_explorer
preview page in the second example.

## 📋 Checklist

- [x] I have read the [contributor
guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md).
- [ ] For large changes, or changes that affect the public API: this
change was discussed or approved through an issue, on
[Discord](https://marimo.io/discord?ref=pr), or the community
[discussions](https://github.com/marimo-team/marimo/discussions) (Please
provide a link if applicable).
- [ ] I have added tests for the changes made.
- [x] I have run the code and verified that it works as expected.

## 📜 Reviewers

<!--
Tag potential reviewers from the community or maintainers who might be
interested in reviewing this pull request.

Your PR will be reviewed more quickly if you can figure out the right
person to tag with @ -->

@akshayka OR @mscolnick

Co-authored-by: Myles Scolnick <myles@marimo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants