fix: use proxy scheme instead of server #4707
Merged
+61
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dmadisetti
previously approved these changes
Apr 28, 2025
spasche
reviewed
Apr 28, 2025
| ws_url = urljoin(ws_target_url, ws_path) | ||
| if scope["scheme"] in ("http", "ws"): | ||
| scheme = urlparse(ws_url).scheme | ||
| if scheme in ("http", "ws"): |
There was a problem hiding this comment.
If the target scheme is already ws or wss, I don't think it needs to be replaced?
Also, that might lead to an unexpected replacement with a target such as ws://example.com/http which would be replaced to ws://example.com/ws.
There was a problem hiding this comment.
you are right. i will fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4584