Skip to content

feat: resizable columns in notebook #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 29, 2025
Merged

feat: resizable columns in notebook #4698

merged 14 commits into from
Apr 29, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Apr 28, 2025 •
edited by mscolnick
Loading

📝 Summary

Adds a drag handle at the right side for column based notebooks.
image

Todo:

  • reordering columns and adjusting the width doesn't save properly
  • dragging a column beyond viewport may not be very smooth
  • move resizable component to common folder (maybe)
  • add tests
  • file rename

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@vercel
Copy link

vercel bot commented Apr 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 4:41pm
marimo-storybook ❌ Failed (Inspect) Apr 29, 2025 4:41pm

@mscolnick
resize touchups (#4729)
44806ce 
- bg color on hover
- refactor to hook
@mscolnick mscolnick marked this pull request as ready for review April 29, 2025 16:43
@mscolnick mscolnick merged commit 86f8ef5 into main Apr 29, 2025
36 of 37 checks passed
@mscolnick mscolnick deleted the sham/resizable-cols-notebook branch April 29, 2025 17:00
@github-actions
Copy link

github-actions bot commented Apr 29, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.3-dev37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick