Skip to content

Conversation

@akshayka
Copy link
Contributor

The previous workflow used an API that doesn't exist on merged pull requests (github.event)

@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 5:58pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 5:58pm

@dmadisetti
Copy link
Collaborator

@akshayka Maybe a semi-superifical change to the readme to test it?

@akshayka
Copy link
Contributor Author

@akshayka Maybe a semi-superifical change to the readme to test it?

@dmadisetti good call, done

@akshayka akshayka merged commit 05a54ab into main Apr 18, 2025
29 of 37 checks passed
@akshayka akshayka deleted the aka/fix-notify-translators branch April 18, 2025 18:02
@github-actions
Copy link

README Translation Update Needed

This PR includes changes to the main README.md. The following translation files may need to be updated:

Translation maintainers, please review the changes in this PR and update your respective README translations accordingly.

CC: @metaboulie @kiwamizamurai @Francisco-G-P

@github-actions
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.12.11-dev12

@akshayka
Copy link
Contributor Author

CC: @metaboulie @kiwamizamurai @Francisco-G-P

We've set up a workflow that will ping owners for translated READMEs whenever the English README is updated. This PR doesn't actually update the README in a meaningful way, but the translated READMEs have drifted from the English one over time. If you all have the time to revise your READMEs, that would be very much appreciated :)

Thanks so much!

@kiwamizamurai
Copy link
Contributor

kiwamizamurai commented Apr 18, 2025

Thank you. I'll update it. This is getting popular in Japan

mscolnick pushed a commit that referenced this pull request Apr 25, 2025
…ty (#4606)

## 📝 Summary

<!--
Provide a concise summary of what this pull request is addressing.

If this PR fixes any issues, list them here by number (e.g., Fixes
#123).
-->

I update README for Japanese

## 🔍 Description of Changes

<!--
Detail the specific changes made in this pull request. Explain the
problem addressed and how it was resolved. If applicable, provide before
and after comparisons, screenshots, or any relevant details to help
reviewers understand the changes easily.
-->

Based on the release notification, I modified the documentation
#4587 (comment)

## 📋 Checklist

- [x] I have read the [contributor
guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md).
- [ ] For large changes, or changes that affect the public API: this
change was discussed or approved through an issue, on
[Discord](https://marimo.io/discord?ref=pr), or the community
[discussions](https://github.com/marimo-team/marimo/discussions) (Please
provide a link if applicable).
- [ ] I have added tests for the changes made.
- [ ] I have run the code and verified that it works as expected.

## 📜 Reviewers

<!--
Tag potential reviewers from the community or maintainers who might be
interested in reviewing this pull request.

Your PR will be reviewed more quickly if you can figure out the right
person to tag with @ -->

@akshayka OR @mscolnick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants