Skip to content

feat: release .env secrets out of experimental #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

feat: release .env secrets out of experimental #4556

merged 1 commit into from
Apr 16, 2025

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Apr 16, 2025 •
edited
Loading

Release dotenv secrets out of experimental.

@vercel
Copy link

vercel bot commented Apr 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 5:42pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 5:42pm

@mscolnick mscolnick merged commit 2a883cd into main Apr 16, 2025
43 of 71 checks passed
@mscolnick mscolnick deleted the ms/ga-secrets branch April 16, 2025 19:43
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.12.10-dev26

@dmadisetti
Copy link
Collaborator

dmadisetti commented Apr 16, 2025

Woops, was still reviewing this will send you a doc instead

dmadisetti
dmadisetti reviewed Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KeyRoundIcon and KeySquareIcon seem like better choices

No obvious way (to the user) on how to get the variables. While in env (are all secrets going to be stuffed in env?), might be worth creating mo.secrets.get/set/has as a public api

I think it's still worth displaying note: setting over http when setting a secret if detected

I liked the UX of space turning into a _ but other characters are not:

fa8649f16f1df68aafab6c7a600b33ab

Thankfully this didn't crash my computer, but accidentally sourcing .env could

dmadisetti pushed a commit that referenced this pull request Apr 17, 2025
@mscolnick @dmadisetti
feat: release .env secrets out of experimental (#4556)
efb5fd2 
Release dotenv secrets out of experimental.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmadisetti dmadisetti dmadisetti left review comments

@akshayka akshayka Awaiting requested review from akshayka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mscolnick @dmadisetti