break: markdown width clamped for more readable typography #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
reviewed
Apr 16, 2025
There was a problem hiding this comment.
- Pure markdown definitely looks better narrower, especially in full and medium views.
- 65ch is quite narrow, even for me. Could we do 80ch, overriding tailwind typography too? That roughly matches compact cell size.
- One issue to think through — this also impacts Python objects, such as tables, that are interpolated into markdown. While narrow text looks good, a narrow table is likely not what the user wants (going back to our decision to default to medium width). Is there any way to design around this? See this example, in which the dataframe cannot expand to its full width.
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.12.11-dev2 |
dmadisetti
pushed a commit
that referenced
this pull request
Apr 17, 2025
Fixes #4548 This is a stylistic breaking change. We previously would make the output 100% regardless of whether it was markdown or not. Now: we make the output 100% width only for non-markdown. Markdown has it's own `max-width` set to `65ch` from the [tailwind typography](https://github.com/tailwindlabs/tailwindcss-typography) defaults. This can be unset via custom css in [app config](https://docs.marimo.io/guides/configuration/theming/), user config, or project config. To unset this add the css: ```css .markdown { max-width: unset !important; } ``` ------ <img width="1800" alt="image" src="https://github.com/user-attachments/assets/6c5db7fd-afb9-40cd-88c3-6f5006ef7042" /> ------- This is inline with how Observable does it as well (thanks to @manzt for pointing this out to me ealier this week unrelated to #4548) --------- Co-authored-by: Akshay Agrawal <akshay@marimo.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4548
This is a stylistic breaking change. We previously would make the output 100% regardless of whether it was markdown or not.
Now: we make the output 100% width only for non-markdown. Markdown has it's own
max-widthset to65chfrom the tailwind typography defaults.This can be unset via custom css in app config, user config, or project config. To unset this add the css:
This is inline with how Observable does it as well (thanks to @manzt for pointing this out to me ealier this week unrelated to #4548)