feat: add expand and collapse all columns to notebook actions menu #4550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All contributors have signed the CLA ✍️ ✅ |
for more information, see https://pre-commit.ci
|
I have read the CLA Document and I hereby sign the CLA |
mscolnick
reviewed
Apr 16, 2025
mscolnick
reviewed
Apr 16, 2025
mscolnick
reviewed
Apr 16, 2025
for more information, see https://pre-commit.ci
…into new-keyboard-shortcuts
for more information, see https://pre-commit.ci
mscolnick
reviewed
Apr 16, 2025
…ollapse or expand and changes behavior based on that
for more information, see https://pre-commit.ci
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.12.10-dev21 |
dmadisetti
pushed a commit
that referenced
this pull request
Apr 17, 2025
…4550) ## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes #123). --> Partially resolves #4163 <img width="323" alt="Screenshot 2025-04-15 at 6 56 22 PM" src="https://github.com/user-attachments/assets/45a2ef2a-2351-4cff-a420-6d77b50901e3" /> Next PR will add this functionality to hotkeys.tsx ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> Created collapseAllColumns and expandAllColumns hooks then added them to the notebook actions menu. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers <!-- Tag potential reviewers from the community or maintainers who might be interested in reviewing this pull request. Your PR will be reviewed more quickly if you can figure out the right person to tag with @ --> @mscolnick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
mscolnick
pushed a commit
that referenced
this pull request
May 5, 2025
## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes #123). --> Updated useSectionCollapse to use collapseAllCells and expandAllCells. Partially resolves #4163 by fixing useSectionCollapse bugs. ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> - Updates #4550 implementation by using expandAllCells and collapseAllCells rather than running expandCell and collapseCell in a loop - Fixes consecutive react renders issue - Fixes Node not in tree errors ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers <!-- Tag potential reviewers from the community or maintainers who might be interested in reviewing this pull request. Your PR will be reviewed more quickly if you can figure out the right person to tag with @ --> @mscolnick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Partially resolves #4163
Next PR will add this functionality to hotkeys.tsx
🔍 Description of Changes
Created collapseAllColumns and expandAllColumns hooks then added them to the notebook actions menu.
📋 Checklist
📜 Reviewers
@mscolnick