chore: bump codemirror-languageserver, fix GitHub Copilot incremental updates #4492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
force-pushed
the
ms/bump-codemirror-ls
branch
from
77ab5be to
2172fe3
Compare
mscolnick
changed the title
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- frontend/package.json: Language not supported
- frontend/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
frontend/src/core/codemirror/copilot/language-server.ts:122
- Ensure that 'getCodes' is imported or defined in this file to avoid a runtime error if it is missing.
const text = getCodes(change.text);
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.12.9-dev32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump codemirror-language server:
Fixes #4464
We don't send incremental edits since it breaks copilot. This also adds some fixes for the websocket proxy and multiple LSPs running at once