Skip to content

Conversation

@AndreyChorniy
Copy link

Description (*)

This PR created to mark interfaces as api, also added small code refactoring changes

Fixed Issues (if relevant)

  1. Mark interfaces and blocks as API #290 Mark interfaces and blocks as API

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@AndreyChorniy
Copy link
Author

@magento run all tests

@nathanjosiah
Copy link
Contributor

@magento run all tests against 2.4.3-develop

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@nathanjosiah
Copy link
Contributor

@AndreyChorniy Can you pull the latest code into your branch. I think that's the bulk of the failures in the builds.

@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

@magento-engcom-team
Copy link

@nathanjosiah the branch with code successfully imported intomagento-commerce/security-package repository. Branch name: imported-magento-security-package-294.

@fredden
Copy link
Member

fredden commented Jul 21, 2021

8d5c176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants