Skip to content

Conversation

@engcom-Kilo
Copy link
Contributor

@engcom-Kilo engcom-Kilo commented Apr 21, 2020

Description (*)

Javascript error by Google reCaptcha script.
Added solution, for skip locked form.

Fixed Issues (if relevant)

  1. Fixes "Uncaught (in promise) null" error and stuck page if try to login in Admin with invalid API for "reCAPTCHA v2|v3 Invisible" keys for  #205: "Uncaught (in promise) null" error and stuck page if try to login in Admin with invalid API for "reCAPTCHA v2|v3 Invisible" keys for

Manual testing scenarios (*)

  1. Enable reCAPTCHA v3 / inline for Admin panel, forgot password page
  2. Try to fill form with reCAPTCHA, forgot password page
  3. Check javascript errors in browser developer console

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…error by Google js,

when API keys of reCAPTCHA is incorrect.
@engcom-Kilo engcom-Kilo added the Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label label Apr 21, 2020
@lenaorobei lenaorobei modified the milestone: 1.0.0 May 20, 2020
@slavvka slavvka added the 2.4-develop: exclude 2.4-develop: exclude label Jun 11, 2020
@ghost ghost added 2.4-develop: 4️⃣ 2.4-develop: :four: and removed 2.4-develop: 4️⃣ 2.4-develop: :four: labels Jun 11, 2020
@mmansoor-magento mmansoor-magento changed the base branch from 1.0-develop to develop November 17, 2020 04:13
@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

@magento-engcom-team
Copy link

@nathanjosiah, an error occurred during the Pull Request import.

@lenaorobei
Copy link
Contributor

@magento-engcom-team
Copy link

@lenaorobei the branch with code successfully imported intomagento-commerce/security-package repository. Branch name: imported-magento-security-package-215.

@magento-cicd2 magento-cicd2 merged commit ce6795c into develop Jun 24, 2021
@nathanjosiah nathanjosiah deleted the security-package/issues/205 branch June 24, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.4-develop: exclude 2.4-develop: exclude Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Progress: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Uncaught (in promise) null" error and stuck page if try to login in Admin with invalid API for "reCAPTCHA v2|v3 Invisible" keys for

7 participants