Support controller src_type for head links #9588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why it's needed? Any custom css should be compiled during setup:static-content:deploy. |
|
I understand that compiling is the best practice, but in the real world
clients want to add _some_ CSS by themselves. We have a lot of customers
with this feature in M1 and now that we are proceeding with upgrades they
keep asking for it.
The project still needs to provide a controller for that, so just merging
this PR doesn't give them the ability to add custom CSS via controller.
Also, this patch influences the <link> tag, and more 'non-crazy real world'
scenarios can be supported, like
https://gist.github.com/kevinSuttle/1997924#html-link-tags. I'm just trying
to give the ability to the developer to render a in-store URL with that.
…On Thu, 11 May 2017 at 07:15, Ihor Sviziev ***@***.***> wrote:
Why it's needed? Any custom css should be compiled during
setup:static-content:deploy.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9588 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASYxzxhgTVBtMMTtOCpMmXOOPWGOfF3ks5r4pmIgaJpZM4NXAvk>
.
|
|
In this case it's better to create some file(s) inside static directory with your code & give link to it. |
|
How can we do that without writing down the baseurl inside the template? As
far as I researched, it isn't possible, and it won't cover the other cases.
…On Thu, 11 May 2017 at 08:15, Ihor Sviziev ***@***.***> wrote:
In this case it's better to create some file(s) inside static directory &
give link to it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9588 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASYx0w-OajxWojjBSbqCr4HQGLjqrYtks5r4qd4gaJpZM4NXAvk>
.
|
magento-team
pushed a commit
that referenced
this pull request
Jul 6, 2017
- fixed backward compatibility issues
magento-team
pushed a commit
that referenced
this pull request
Jul 6, 2017
|
which versions of magento was it merged to? Is it fixed in 2.1.x? |
|
Hi @OZZlE, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Magento\Framework\View\Page\Config\Generator\Head::SRC_TYPE_CONTROLLERwas foreseen but never implemented. This small PR allows to define<link>tags with dynamic URLs linking back to the current store.Example
This will render:
Given that
http://magento.dev/is the Base URL.