-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group #39822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
|
Hi @thomas-kl1. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento create issue |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests |
engcom-Hotel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @thomas-kl1,
Thanks for the contribution!
The code changes seems fine to us, but please add/update the automated test with the modified logic.
Thanks
|
Hello @thomas-kl1, Gentle reminder for this PR. Thank you. |
|
@engcom-Hotel it's on my todo list! |
Description (*)
When using \Magento\Catalog\Helper\Data::getTaxPrice to fetch price, tax details are miscalculated for context with guest users.
Here the group id 0 was interpreted as NULL while it shouldn't.
Contribution checklist (*)
Resolved issues: