Skip to content

Conversation

@thomas-kl1
Copy link
Member

@thomas-kl1 thomas-kl1 commented Apr 16, 2025

Description (*)

When using \Magento\Catalog\Helper\Data::getTaxPrice to fetch price, tax details are miscalculated for context with guest users.

Here the group id 0 was interpreted as NULL while it shouldn't.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group #39850: Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2025

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 22, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Apr 22, 2025
@thomas-kl1
Copy link
Member Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thomas-kl1,

Thanks for the contribution!

The code changes seems fine to us, but please add/update the automated test with the modified logic.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Sep 15, 2025
@engcom-Hotel
Copy link
Contributor

Hello @thomas-kl1,

Gentle reminder for this PR.

Thank you.

@engcom-Charlie engcom-Charlie self-assigned this Oct 7, 2025
@thomas-kl1
Copy link
Member Author

@engcom-Hotel it's on my todo list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: Community Picked PRs upvoted by the community

Projects

Status: Changes Requested

Development

Successfully merging this pull request may close these issues.

[Issue] Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group

3 participants