Skip to content

Customer email confirmation rate limit #39814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: 2.4-develop
Choose a base branch
from
Open

Customer email confirmation rate limit #39814

wants to merge 9 commits into from

Conversation

@Mohamed-Asar
Copy link
Contributor

@Mohamed-Asar Mohamed-Asar commented Apr 15, 2025

Description (*)

Rate limit enabled for customer confirmation link email

Fixed Issues (if relevant)

  1. Fixes Rate limit not available for customer confirmation link email #39813

Manual testing scenarios (*)

  1. Enable Email Confirmation required for customer signup
  2. Create a customer account
  3. Go to customer confirmation link page(/customer/account/confirmation)
  4. Try request multiple confirmation link for the same email

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2025

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Mohamed-Asar
Copy link
Contributor Author

Mohamed-Asar commented Apr 15, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Apr 15, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Apr 15, 2025
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Sep 12, 2025
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Sep 17, 2025

Hello @Mohamed-Asar,

Thanks for the contribution!

Please resolve the conflicts in this PR. In the meantime, I am moving this PR to the "On Hold" bucket.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to On Hold in Community Dashboard Sep 17, 2025
@Mohamed-Asar
Copy link
Contributor Author

Mohamed-Asar commented Sep 17, 2025

@engcom-Hotel I fixed the conflicts, please review

@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Sep 18, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review September 18, 2025 06:45
@engcom-Hotel engcom-Hotel moved this from On Hold to Review in Progress in Community Dashboard Sep 18, 2025
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Sep 18, 2025

Hello @Mohamed-Asar,

Thanks for resolving the conflicts!

Since the related issue is categorised as feature request, we have sent an email to the PO for approval.

Meanwhile we are moving this PR on hold.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to On Hold in Community Dashboard Sep 18, 2025
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Oct 28, 2025

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mohamed-Asar,

We have received an approval from the PO to proceesd further with this PR. Please fix the failed tests and check the below review comments.

Thank you

app/code/Magento/Customer/Model/AccountManagement.php Outdated
* @param Backend|null $eavValidator
* @param CustomerLogger|null $customerLogger
* @param Authenticate|null $authenticate
<<<<<<< HEAD
Copy link
Contributor

@engcom-Hotel engcom-Hotel Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these conflict text.

Copy link
Contributor Author

@Mohamed-Asar Mohamed-Asar Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove this

app/code/Magento/Customer/etc/adminhtml/system.xml
<label>Confirmation Link Email</label>
<comment>Email template chosen based on theme fallback when "Default" option is selected.</comment>
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>
<depends>
Copy link
Contributor

@engcom-Hotel engcom-Hotel Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this feature disable by default in accordance to maintain the backward compatibility.

Copy link
Contributor Author

@Mohamed-Asar Mohamed-Asar Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Hotel i've added config to enable or disable this feature, by default its disabled

@engcom-Hotel engcom-Hotel moved this from On Hold to Changes Requested in Community Dashboard Oct 29, 2025
@Mohamed-Asar
Copy link
Contributor Author

Mohamed-Asar commented Oct 30, 2025

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Changes Requested to Review in Progress in Community Dashboard Oct 30, 2025
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Oct 31, 2025

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mohamed-Asar,

It seems some of the automated tests are failing due to the PR changes. Please refer to the failed tests.

Thank you

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Oct 31, 2025
@Mohamed-Asar
Copy link
Contributor Author

Mohamed-Asar commented Oct 31, 2025

@engcom-Hotel Let me check and fix the failed test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees

No one assigned

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Progress: on hold Project: Community Picked PRs upvoted by the community

Projects

Community Dashboard
Status: Changes Requested

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rate limit not available for customer confirmation link email

3 participants

@Mohamed-Asar @engcom-Hotel @engcom-Charlie