Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape disabled modules in code compilation - setup:di:compile #39723

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

lucafuser
Copy link
Contributor

Description (*)

As disabled module is being compiled, so in this PR I've escaped disabled modules before code compilation.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Compling code of disabled module. #38241

Manual testing scenarios (*)

  1. In app/etc/config.php set "0" to a module OR run php bin/magento module:disable Vendor_Module
  2. Run php bin/magento setup:di:compile

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Mar 8, 2025

Hi @lucafuser. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lucafuser
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 10, 2025
@lucafuser
Copy link
Contributor Author

@magento run all tests

Comment on lines 170 to 173
if (!$moduleStatuses || !is_array($moduleStatuses)) {
$output->writeln('<error>Deployment config not available.</error>');
return Cli::RETURN_FAILURE;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you pointed in https://github.com/magento/magento2/pull/39723/files#r1990180085, this was already checked in

$errors = $this->checkEnvironment();

I guess we can simply remove these lines

Suggested change
if (!$moduleStatuses || !is_array($moduleStatuses)) {
$output->writeln('<error>Deployment config not available.</error>');
return Cli::RETURN_FAILURE;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@lucafuser
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compling code of disabled module.
4 participants