Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#39640: Issue with the Customizable Options grid on the product page in the admin panel #39694

Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#39640: Issue with the Customizable Options grid on the product page in the admin panel #39694

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
596503a
magento/magento2#39481: Completely removing a gallery-image from be k…
pavel77718 Feb 28, 2025
baf8e32
magento/magento2#39481: Completely removing a gallery-image from be k…
pavel77718 Feb 28, 2025
7be854d
Merge branch '2.4-develop' into 2.4-develop
pavel77718 Feb 28, 2025
8b59433
magento/magento2#39640: Completely removing a gallery-image from be k…
pavel77718 Mar 3, 2025
01ef988
magento/magento2#39640: Issue with the Customizable Options grid on t…
pavel77718 Mar 4, 2025
437194c
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 5, 2025
12573ad
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 5, 2025
87596ac
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 5, 2025
1c22ed9
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 6, 2025
58d8be7
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 6, 2025
83e8386
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 7, 2025
6070cf5
Merge branch '2.4-develop' into fix-for-issue-39640
pavel77718 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2015 Adobe
* All Rights Reserved.
*/

/**
Expand Down Expand Up @@ -689,14 +689,16 @@ define([
* @param {Number|String} prop - additional property to element
*/
processingAddChild: function (ctx, index, prop) {
var newTotal,
newPages;

this.bubble('addChild', false);

if (this.relatedData.length && this.relatedData.length % this.pageSize === 0) {
this.pages(this.pages() + 1);
this.nextPage();
} else if (~~this.currentPage() !== this.pages()) {
this.currentPage(this.pages());
}
newTotal = this.relatedData.length + 1;
newPages = Math.ceil(newTotal / this.pageSize);

this.pages(newPages);
this.currentPage(newPages);

this.addChild(ctx, index, prop);
},
Expand Down