-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reprocess PR 39097 fixes requireJS mixins racecondition with require calls in dom #39691
base: 2.4-develop
Are you sure you want to change the base?
Conversation
… loads before dom parse
…bapiui jquery-mixin load before require calls in dom
based on acceptance of requirejs/requirejs/pull/1859 removes nextTick cause of race condition
# Conflicts: # lib/web/requirejs/require.js
Hi @ioweb-gr. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
Description (*)
This is an attempt to reprocess the race condition issue with mixins not loading from PR #39097 because it has been stale for very long waiting to be merged with the 2.4-develop branch. I resolved all merge conflicts and here is the new one. Hopefully this will work the same as I noticed on 2.4.-develop a lot of require.js changes were included.
Related Pull Requests
#39097
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)