Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39353 Added sanitization of address fields for the presence of template variables in the customer address #39673

Open
wants to merge 8 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

rostilos
Copy link
Contributor

@rostilos rostilos commented Feb 28, 2025

Description (*)

Added sanitize for address fields. Added for abstract address model class to avoid template processor handling variables specified directly in the address.
{{ template_var }} -> {{ template_var }}

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Address Book Bug] Template filter \Magento\Framework\Filter\Template cannot deal with improper input #39353

Manual testing scenarios (*)

  1. When creating or editing an address ( storefront/adminhtml ), enter into any of the address fields a template variable of the following form : {{if city}}{{var city}}, {{/if}}
  2. Check if there is a validation error

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Feb 28, 2025

Hi @rostilos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2025
@rostilos
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Feb 28, 2025
…plate-vars-in-customer-addr' into fix-for-issue-39353-validate-template-vars-in-customer-addr
@rostilos
Copy link
Contributor Author

@magento run all tests

@rostilos rostilos marked this pull request as draft March 2, 2025 12:33
rostilos added 2 commits March 2, 2025 16:04
…plate-vars-in-customer-addr' into fix-for-issue-39353-validate-template-vars-in-customer-addr
@rostilos rostilos marked this pull request as ready for review March 2, 2025 14:07
@rostilos
Copy link
Contributor Author

rostilos commented Mar 2, 2025

@magento run all tests

@rostilos
Copy link
Contributor Author

rostilos commented Mar 2, 2025

@magento run all tests

@rostilos rostilos changed the title #39353 Added validation for the presence of template variables in the… #39353 Added sanitization of address fields for the presence of template variables in the customer address Mar 2, 2025
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Mar 13, 2025
@rostilos
Copy link
Contributor Author

@magento run all tests

Copy link

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

…te-template-vars-in-customer-addr

# Conflicts:
#	app/code/Magento/Customer/etc/di.xml
@rostilos
Copy link
Contributor Author

@magento run all tests

@rostilos
Copy link
Contributor Author

@magento run Functional Tests EE, Functional Tests B2B, Functional Tests CE

@rostilos
Copy link
Contributor Author

I don't see a direct correlation between my edits and errors on most tests.
But I would like to clarify : what should I do to eliminate this error in the tests (which is obviously caused by my edits) ?
Screenshot_20250321_105116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Project: Community Picked PRs upvoted by the community
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

[Address Book Bug] Template filter \Magento\Framework\Filter\Template cannot deal with improper input
4 participants