-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyedit: change "coping" to "copying" #39307
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @ckd. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento create issue |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ckd,
Thanks for the contribution!
The changes seem good to us but please fix the static test failures.
Also I want to suggest to fix a typo in the below line as well (startegt to strategy):
* Validation startegt field name |
Hi @engcom-Hotel! Added the additional typo correction to the PR, but the static test failures seem to be upstream and unrelated to this change |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ckd, for making the changes.
But we are still having static test failures. Please fix those.
@engcom-Hotel those failures are out of scope for this PR, they need to be fixed upstream |
Hello @ckd, we can see the copywrite failures on the files in this PR. You just need to make the changes in the file as follows:
|
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magento run all tests |
@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Unit Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ckd,
Thanks for fixing the issues!
But we are still having some static test failures. Please fix those and then run all tests to verify.
Thanks
Hello @ckd, We are picking this PR for further processing. Thanks |
@magento run all tests |
@magento run Static Tests |
Hi @ckd, Thanks for the collaboration & contribution! ✔️ QA PassedThanks. |
@magento run all tests |
1 similar comment
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE |
Description (*)
Minor copyedit to correct spelling of "copying"
Related Pull Requests
n/a
Fixed Issues (if relevant)
n/a
Manual testing scenarios (*)
n/a
Questions or comments
n/a
Contribution checklist (*)
Resolved issues: