Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fedex Carrier.php with missing rates #39087

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

mattyl
Copy link

@mattyl mattyl commented Aug 22, 2024

Add missing rates

            'FEDEX_REGIONAL_ECONOMY' => __('Regional Economy'),
            'FEDEX_INTERNATIONAL_PRIORITY_EXPRESS' => __('Internationa Priority Express'),

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Update fedex Carrier.php with missing rates #39094: Update fedex Carrier.php with missing rates

Add missing rates

                'FEDEX_REGIONAL_ECONOMY' => __('Regional Economy'),
                'FEDEX_INTERNATIONAL_PRIORITY_EXPRESS' => __('Internationa Priority Express'),
Copy link

m2-assistant bot commented Aug 22, 2024

Hi @mattyl. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Aug 22, 2024
@@ -724,6 +724,8 @@ public function getCode($type, $code = ''): \Magento\Framework\Phrase|array|fals
'STANDARD_OVERNIGHT' => __('Standard Overnight'),
'FEDEX_FREIGHT' => __('Freight'),
'FEDEX_NATIONAL_FREIGHT' => __('National Freight'),
'FEDEX_REGIONAL_ECONOMY' => __('Regional Economy'),
'FEDEX_INTERNATIONAL_PRIORITY_EXPRESS' => __('Internationa Priority Express'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed - but not where its important - fixed the label!
There are many other rates available - the ones i added are helpful for UK merchants

fixed typo in label
@plac2
Copy link

plac2 commented Jan 27, 2025

We added the services manually.
Now I see "Regional Economy" on the backend, but not in the frontend.
Should I upgrade to 2.4.7?
I am currently on 2.4.6-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Update fedex Carrier.php with missing rates
5 participants