-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fedex Carrier.php with missing rates #39087
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Add missing rates 'FEDEX_REGIONAL_ECONOMY' => __('Regional Economy'), 'FEDEX_INTERNATIONAL_PRIORITY_EXPRESS' => __('Internationa Priority Express'),
Hi @mattyl. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento create issue |
@@ -724,6 +724,8 @@ public function getCode($type, $code = ''): \Magento\Framework\Phrase|array|fals | |||
'STANDARD_OVERNIGHT' => __('Standard Overnight'), | |||
'FEDEX_FREIGHT' => __('Freight'), | |||
'FEDEX_NATIONAL_FREIGHT' => __('National Freight'), | |||
'FEDEX_REGIONAL_ECONOMY' => __('Regional Economy'), | |||
'FEDEX_INTERNATIONAL_PRIORITY_EXPRESS' => __('Internationa Priority Express'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed - but not where its important - fixed the label!
There are many other rates available - the ones i added are helpful for UK merchants
fixed typo in label
We added the services manually. |
Add missing rates
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: