Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warning: Undefined array key "filters" #38996

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Fix Warning: Undefined array key "filters" #38996

merged 7 commits into from
Nov 1, 2024

Conversation

thomas-kl1
Copy link
Member

@thomas-kl1 thomas-kl1 commented Aug 2, 2024 •
edited by m2-assistant bot
Loading

Description (*)

Fresh Install, when a new user does not have played with bookmarks yet, this silenced error is logged.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix Warning: Undefined array key "filters" #39013: Fix Warning: Undefined array key "filters"

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 2, 2024

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Dn’D partners-contribution Pull Request is created by Magento Partner labels Aug 2, 2024
@thomas-kl1
Copy link
Member Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 6, 2024
Closed
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 6, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Static Tests

@engcom-Hotel engcom-Hotel self-requested a review September 18, 2024 10:55
engcom-Hotel
engcom-Hotel requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thomas-kl1,
Thanks for the contribution!

Please add the doc block as suggested below.

Thanks

thomas-kl1 and others added 2 commits September 18, 2024 15:44
@thomas-kl1 @engcom-Hotel
Add missing phpdoc
e462adc 
Co-authored-by: Abhinav Pathak <51681618+engcom-Hotel@users.noreply.github.com>
@thomas-kl1
Fix phpcs
d4795df
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie self-assigned this Sep 19, 2024
@engcom-Charlie
Copy link
Contributor

It seems that review changes has been covered so moved it back to review

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @thomas-kl1,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

A lot of "Fix Warning: Undefined array key "filters" errors pop in the logs when using the Admin views (ui grids).

Before: ✖️ 

main.CRITICAL: Exception: Warning: Undefined array key "filters" in /usr/local/var/www/magentok/magento2/app/code/Magento/Ui/Controller/Adminhtml/Bookmark/Save.php on line 250 in /usr/local/var/www/magentok/magento2/lib/internal/Magento/Framework/App/ErrorHandler.php:62

After: ✔️

There will be No Error in the Logs.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Semantic Version Checker, Functional Tests B2B, Functional Tests CE

@engcom-Charlie
Copy link
Contributor

Functional B2B and CE failures in recent 2 builds are not consistent. They are not related to PR or not failing because of PR changes, seems to be flaky. Hence moving this PR to Merge in Progress.

Functional B2B: Run1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/43f32231cb1a5e50d3ad4a58a1e1e303/Functional/allure-report-b2b/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/a464976bc37b6cb5b82b31a51a9949bf/Functional/allure-report-b2b/index.html#categories

image

Functional CE: Run1:

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/88db4508464058e6323f57d14f892641/Functional/allure-report-ce/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38996/c5ea7735164fde9706863e259a29c0fa/Functional/allure-report-ce/index.html#categories

image

@thomas-kl1
Copy link
Member Author

Hello @engcom-Charlie , any idea if there's a chance this PR pass with next release?

@engcom-Charlie
Copy link
Contributor

Hello @engcom-Charlie , any idea if there's a chance this PR pass with next release?

Hi @thomas-kl1,

We are trying to get it merge soon. We will notify you here once it will get merge.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 7db7c5e into magento:2.4-develop Nov 1, 2024
9 of 11 checks passed
@hostep hostep mentioned this pull request Nov 5, 2024
Closed
5 tasks
@Calvin495
Copy link

@engcom-Charlie
This fix is not in Magento 2.4.7-p1. Is there an official patch available for this fix?

@thomas-kl1
Copy link
Member Author

Hello @Calvin495 you can use the diff and apply it as a patch.

@Calvin495
Copy link

@thomas-kl1

Thanks. That was the last resort :)

Is this fix included in 2.4.7-p2?

@thomas-kl1
Copy link
Member Author

This fix has been merged on November 1st, the 2.4.7-p2 has been released on August 9th. 😄

For now the fix is only in the develop branch and is not part of any release yet.

@Calvin495
Copy link

@thomas-kl1

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

Labels
Partner: Dn’D partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix Warning: Undefined array key "filters"
8 participants
@thomas-kl1 @engcom-Hotel @engcom-Charlie @engcom-Bravo @Calvin495 @magento-devops-reposync-svc @m2-github-services @Priyakshic