Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento#38805: Issue at product import when provided with custom options-type: file #38926

Merged
merged 3 commits into from
Sep 5, 2024
Merged

magento#38805: Issue at product import when provided with custom options-type: file #38926

merged 3 commits into from
Sep 5, 2024

Conversation

Yaroslav1301
Copy link
Contributor

Ensure the import with custom options works properly for the 'file' type.

Description (*)

  • Fixed the issue with parsing 'file_extension' data.
  • Resolved the issue where the price was not set for the custom-options file type.

Fixed Issues (if relevant)

  1. Fixes Issue at product import when provided with custom options-type: file (Created Product does not contain price for custom-option and show only the first file type extension provided) #38805

Manual testing scenarios (*)

  1. Create a CSV file for product import.
  2. Add the necessary data for the product along with custom options.
  3. Add the type file and other data for the custom options column. Ensure you include more than one file_extension attribute.
  4. Navigate to System > Import.
  5. Choose Entity type: Products and Import behavior: Add/Update. Leave the remaining settings as default (separators: ",").
  6. Validate and import the product.
  7. Check the created product customization options section on the edit product page. Ensure the price is set and file extensions are displayed properly.

Attached the CSV used during the testing.
catalog_product.csv

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@Yaroslav1301
magento#38805: Issue at product import when provided with custom opti…
df87854 
…ons-type: file

 - Fixed issue with parsing 'file_extension' data.
 - Resolved the issue where the price was not set for the file custom-options type.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 12, 2024

Hi @Yaroslav1301. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner labels Jul 12, 2024
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jul 12, 2024
@Yaroslav1301
Copy link
Contributor Author

@magento run all tests

@Yaroslav1301
Copy link
Contributor Author

@magento run all tests

@Yaroslav1301
Copy link
Contributor Author

@magento run Functional Tests CE

@Yaroslav1301
Copy link
Contributor Author

@magento run Functional Tests EE, Functional Tests B2B

@Yaroslav1301
Copy link
Contributor Author

@magento run Functional Tests EE, Functional Tests B2, Functional Tests CE

@Yaroslav1301
Copy link
Contributor Author

Functional Tests CE failures are different on last two run on same commit:
Run 1
image

Run 2
image

Functional Tests B2B - not related to my PR.
image

Functional Tests EE - not related to my PR.
image

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Jul 17, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review July 22, 2024 06:32
@engcom-Bravo engcom-Bravo self-assigned this Jul 22, 2024
@engcom-Bravo
Copy link
Contributor

Hi @Yaroslav1301,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create a CSV file for product import.
  • Add the necessary data for the product along with custom options.
  • Add the type file and other data for the custom options column. Ensure you include more than one file_extension attribute.
  • Navigate to System > Import.
  • Choose Entity type: Products and Import behavior: Add/Update. Leave the remaining settings as default (separators: ",").
  • Validate and import the product.
  • Check the created product customization options section on the edit product page. Ensure the price is set and file extensions are displayed properly.

Before: ✖️ 

Screenshot 2024-07-23 at 14 16 10

After: ✔️

Screenshot 2024-07-23 at 14 35 53

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Charlie engcom-Charlie self-assigned this Jul 24, 2024
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jul 25, 2024 •
edited
Loading

Few test failures in recent 2 builds for functional B2B, CE are not consistent and remaining are known issues.

Functional B2B: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38926/160c52709da3872f5873915709e1150a/Functional/allure-report-b2b/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38926/c99967efa9bb347827a643d0abb829f1/Functional/allure-report-b2b/index.html#categories/a644910ae0cb11e839a98baa21929b76/1c476d5ca9970f9c/

image

Functional CE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38926/746b3df14d5756d6ce0feede76e3e107/Functional/allure-report-ce/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38926/d62c4097e55b8751f68360331ac30175/Functional/allure-report-ce/index.html#categories/a644910ae0cb11e839a98baa21929b76/64d6147e8b1a2527/

image

Known issues in B2B and CE:

  1. StorefrontAddBundleDynamicProductToShoppingCartWithDisableMiniCartSidebarTest: #ACQE-6786
  2. StorefrontLoginFormCheckDuplicateValidateMessageTest: #ACQE-6799
  3. TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest: #ACQE-6695
  4. StorefrontCashOnDeliveryPaymentForSpecificCountryTest: #ACQE-6774

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jul 25, 2024 •
edited
Loading

Few test failures in recent 2 builds for functional EE are not consistent and remaining are known issues. Hence moving this to Merge in Progress

Functional EE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38926/2275c173863de41716cbc9f636ca56d3/Functional/allure-report-ee/index.html#categories/a62c3d6db6631ba28c4130df03eca285/40aabd6b5fd9b4b/

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38926/c1659c8a572ba859325dd65148e32337/Functional/allure-report-ee/index.html#categories/8f0831c1d06562890f5ec21062dae309/2f40d06202ced82e/

image

Known issues in EE:

  1. StorefrontAddBundleDynamicProductToShoppingCartWithDisableMiniCartSidebarTest: #ACQE-6786
  2. StorefrontCashOnDeliveryPaymentForSpecificCountryTest: #ACQE-6774
  3. StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331
  4. StorefrontLoginFormCheckDuplicateValidateMessageTest: #ACQE-6799
  5. TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest: #ACQE-6695
  6. BannerValidateVideoBackgroundVideoURLs: #ACQE-6828

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 16f40c1 into magento:2.4-develop Sep 5, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

Labels
Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community
Projects
None yet
Milestone
No milestone
7 participants
@Yaroslav1301 @engcom-Hotel @engcom-Bravo @engcom-Charlie @sinhaparul @magento-devops-reposync-svc @m2-github-services