Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies of magento/framework #3889

Merged
merged 6 commits into from
Jun 30, 2017
Merged

Add missing dependencies of magento/framework #3889

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c47904
magento/framework should require zendframework/zend-http
GordonLesti Mar 24, 2016
a4ec8fb
add all dependencies of magento/framework
GordonLesti Apr 8, 2016
2d669c3
Merge remote-tracking branch 'upstream/develop' into require_zend_http
GordonLesti May 6, 2016
87749de
Merge remote-tracking branch 'upstream/develop' into require_zend_http
GordonLesti Mar 28, 2017
9b33632
alphabetical order of third party dependencies
GordonLesti Mar 28, 2017
e12db94
update version of dependencies
GordonLesti Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/internal/Magento/Framework/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"ext-openssl": "*",
"lib-libxml": "*",
"ext-xsl": "*",
"symfony/process": "~2.1"
"symfony/process": "~2.1",
"zendframework/zend-http": "~2.4.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no need to prevent updating to 2.5 and more. So better to use ~2.4. If it should be more than 2.4.6 - ~2.4 >=2.4.6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^2.4.6 can be used as shorthand for >=2.4.6,<3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have taken the requirement from magento/magento2ce composer.json and that is "zendframework/zend-http": "~2.4.6" at the moment.

},
"suggest": {
"ext-imagick": "Use Image Magick >=3.0.0 as an optional alternative image processing library"
Expand Down