Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when compiling statics with multiple jobs #38842

Conversation

mrodespin
Copy link
Contributor

@mrodespin mrodespin commented Jun 19, 2024

Copy link

m2-assistant bot commented Jun 19, 2024

Hi @mrodespin. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jun 20, 2024
@jellesiderius
Copy link

Can confirm that this fixes my issues.

@monteshot
Copy link
Contributor

@magento run all tests

@engcom-Delta engcom-Delta added the Project: Community Picked PRs upvoted by the community label Aug 16, 2024
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mrodespin,

Thanks for the collaboration!

Please refer to my review comment below.

Thanks

Co-authored-by: Abhinav Pathak <51681618+engcom-Hotel@users.noreply.github.com>
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @mrodespin,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Go to env.php
  • Set the port information to the host in the db connection. e.g. db['connection']['default']['host'] = 'localhost:3306'
  • Execute ./magento.sh setup:static-content:deploy

Before: ✖️ 

Screenshot 2024-08-22 at 12 23 47

After: ✔️

Screenshot 2024-08-22 at 13 32 33

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Charlie engcom-Charlie self-assigned this Aug 25, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit e6ad856 into magento:2.4-develop Sep 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme compilation breaks when mysql host contains port information
9 participants