Columns functionality for \Magento\Theme\Block\Html\Topmenu seems broken

[rogerdz]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Columns functionality for \Magento\Theme\Block\Html\Topmenu seems broken #38326

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Static Tests

[engcom-Hotel]

Hello @rogerdz,

Thanks for the contribution!

The changes looks good to me but please add an automated test in order to test the functionality.

[engcom-Dash]

@magento run Unit Tests

[engcom-Hotel]

Moving back to Changes Requested as the Unit Tests are still failing.

[engcom-Dash]

@magento run Unit Tests

[engcom-Dash]

@magento run Unit Tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Code changes good to me. For SVC failure we need to raise the approval ticket.

[engcom-Hotel]

@magento run Functional Tests B2B

[engcom-Dash]

Hello @rogerdz

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop
Steps to reproduce
According to the issue description.
Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Dash]

Raised internal approval Jira for the SVC failure. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals.