Updage seletor style in _message.les

[vitinhomorais00]

Description (*)

Adjustment in the styled element, so that there is no validation break when loading the style in email and in the frontend.

Related Pull Requests

vitinhomorais00/magento2@2.4-develop...vitinhomorais00-patch-1

Manual testing scenarios (*)

1. Custom theme password reset flow (header and footer)
2. Receive an email

Questions or comments

A footer and header template was created in a custom theme.
We manually took the styling from the file: lib/web/css/docs/source/_messages.less and included it in the theme.

Doing so always returns the error CSS inlining error: Warning: Uninitialized string offset 5 in /var/www/html/Magento2/vendor/sabberworm/php-css-parser/src/Value/Color.php on line 56 view the email in a provider (gmail, outlook, mailinator, etc).

We found the error in this line of code: @message-custom-icon__background: #green;
The correct one would be @message-custom-icon__background: green;

So, before it was giving an error during the compilation of the inline CSS in the email, when adjusting this styling it worked again.

We noticed that the same instruction exists in the native file and it would be interesting to have its value correct.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Updage seletor style in _message.les #39308: Updage seletor style in _message.les

[m2-assistant]

Hi @vitinhomorais00. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[vitinhomorais00]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[vitinhomorais00]

@magento give me test instance

[magento-deployment-service]

Hi @vitinhomorais00. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @vitinhomorais00. Thank you for your request. I'm working on Magento instance for you.

[vitinhomorais00]

run all tests

[magento-deployment-service]

Hi @vitinhomorais00, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[magento-deployment-service]

Hi @vitinhomorais00, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[vitinhomorais00]

run all tests

[vitinhomorais00]

run all tests

[vitinhomorais00]

run all tests

[Den4ik]

@vitinhomorais00 Please sign CLA

[vitinhomorais00]

@Den4ik CLA was signed. What would be the next step?
An observation that I forgot to mention, this error only occurs in mode:production, so it is a very difficult error to occur, but at the same time serious.
I'm waiting.

[vitinhomorais00]

@magento run all testes

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

✅ Changes looks good for me and don't require additional tests

[vitinhomorais00]

@Den4ik Thanks. I will wait for the next steps.

[vitinhomorais00]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[vitinhomorais00]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[vitinhomorais00]

@Den4ik Do you know an estimate where the tests end?

[Den4ik]

@Den4ik Do you know an estimate where the tests end?

It will be QAed according to priorities of internal team. Please wait updates

[vitinhomorais00]

@Den4ik Thanks for the update, I'll wait for updates from the team.

[vitinhomorais00]

@magento run all tests

[engcom-Dash]

Manual testing is not required since this corrects the color format from invalid #green to green.

Builds are failed. Hence moving it to Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

The Functional CE and B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36698/ae30ab32fc584652a05a9eb4fa4e239d/Functional/allure-report-ce/index.html#categories/8f0831c1d06562890f5ec21062dae309/1c675fd34064e367/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36698/45becc1486550a527c510ce64b9a9860/Functional/allure-report-ce/index.html#categories/a644910ae0cb11e839a98baa21929b76/842d2c59976ef09d/

Functional Tests B2B:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36698/582a09c595b79ef88d01edcf99257bf1/Functional/allure-report-b2b/index.html#categories/2afd3b34d66263d23832312f8fed37f1/b87e7f81fa518a70/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36698/ef5012cdafff559195b1c2609fa770e8/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/f649bdcfbee95691/

[engcom-Dash]

@magento create issue