Product layout based on attribute_set

[in-session]

Currently there is only the possibility to adjust the layout by SKU or by types of the product. In most productive cases, however, this is only partly practical. because it then only refers to many articles or one article. With the integration the layout can be used based on the attribute set similar to an article group, which is more needed in most cases. The display of the articles are controlled in the backend by attribute_set, so there should be a way to pass this to the frontend store as well.

https://developer.adobe.com/commerce/frontend-core/guide/layouts/product-layouts/

LAYOUT FILE	DESCRIPTION
catalog_product_view.xml	Common layout. Affects all product types
catalog_product_view_type_bundle.xml	Layout from this file is applied to bundle product only
catalog_product_view_type_configurable.xml	Layout from this file is applied to configurable product only
catalog_product_view_type_downloadable.xml	Layout from this file is applied to downloadable product only
catalog_product_view_type_grouped.xml	Layout from this file is applied to grouped product only
catalog_product_view_type_simple.xml	Layout from this file is applied to simple product only
catalog_product_view_type_virtual.xml	Layout from this file is applied to virtual product only
catalog_product_view_id_{id}.xml	Layout from this file is applied to the specific product by Entity ID value. E.g. catalog_product_view_id_45.xml
catalog_product_view_attribute_set_{id}.xml	Layout from this file is applied to the specific product attribute set by Entity ID value. E.g. catalog_product_view_attribute_set_45.xml
catalog_product_view_sku_{sku}.xml	Layout from this file is applied to the specific product by SKU value. E.g. catalog_product_view_sku_24-WG080.xml

Example: catalog_product_view_attribute_set_15.xml
Controls the front-end display of all items that are within the Bags group.

Resolved issues:

1. resolves [Issue] Product layout based on attribute_set #38790: Product layout based on attribute_set

[in-session]

@magento run all tests

[m2-assistant]

Hi @in-session. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[in-session]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @in-session. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @in-session, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[in-session]

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE,Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[in-session]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Hotel]

@magento run all tests

[engcom-November]

As the linked issue is marked as feature request, moving the PR to On hold till we get PO confirmation.

Thank you.

[MaximGns]

Can this field be configurable? As the existing layout handle for sku/id based is already increasing the load on the layout cache...

Please see: #102 (comment)
This change can only cause it to increase it even further...

[toonvd]

RIP cache performance. This and the sku/id layout handle should indeed be off by default and have a field in sysconfig to activate it.

[engcom-Charlie]

As we got the confirmation from Product Owner on this feature request issue, moving it back to Extended testing.

As the linked issue is marked as feature request, moving the PR to On hold till we get PO confirmation.

Thank you.

[engcom-Charlie]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests EE, Functional Tests B2B

[engcom-Dash]

The Functional B2B and EE test failures seem to be flaky and also there is a known issue for EE test. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36244/8529c1c6babf2ff839a59907d6d68e32/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36244/28a163a7090cb4998f4680130f4e9922/Functional/allure-report-b2b/index.html#categories/75b40a63f79830217aae704c6d6af940/6fcd5f2baec69fce/

Functional Tests EE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36244/a981cb257cb467e9522df2daf97d3ff5/Functional/allure-report-ee/index.html#categories/75b40a63f79830217aae704c6d6af940/6705b0130214d5b6/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36244/50bec6534207904c60384b4e88d28760/Functional/allure-report-ee/index.html#categories/75b40a63f79830217aae704c6d6af940/d46e8065d481bea1/

Known Issue:
StoreFrontAddOutOfStockProductToShoppingCartTest: ACQE-6818

[hostep]

@engcom-Charlie or @engcom-Dash: have these 2 comments been taken into consideration and/or have been verified if true?

• Product layout based on attribute_set #36244 (comment)
• Product layout based on attribute_set #36244 (comment)

If this change causes caching storage to increase significantly, it may not have been a good idea to merge it, unless there is an easy way to disable this.

[IvanChepurnyi]

There is definitely going to be a lot of issues in future for Redis cache being blown up, unless we completely change Magento Layout building mechanism like I did before for Magento 1 (compile layouts handles into own files and then include them)

[toonvd]

@engcom-Charlie @engcom-Dash agencies are even implementing fixes to be able to disable the handles. Please reconsider this.

https://github.com/Vendic/module-optimize-cache-size/tree/main

[engcom-Charlie]

Hi @in-session,

Thank you for the contribution!

@hostep @toonvd @IvanChepurnyi @MaximGns thank you for providing your valuable thoughts on this. I have gone through all the comments about making this change as a configurable one. As this PR is already merged, requesting the community to raise a Pull Request to address this new change. We will see to take it further as per the process.

• Product layout based on attribute_set #36244 (comment)
• Product layout based on attribute_set #36244 (comment)
• Product layout based on attribute_set #36244 (comment)

[in-session]

@engcom-Charlie after some consideration I think the catalog_product_view_attribute_set_{id}.xml would certainly be used more than the catalog_product_view_id_{id}.xml. Still, in terms of feedback, it wouldn't be a bad idea to make it an optional future. I have therefore made another PR, which makes it possible to activate or deactivate this, as well as the layout of the products id.

@hostep @toonvd @IvanChepurnyi @MaximGns - FYI
#39718

[engcom-Charlie]

Thank you @in-session.

Thank you for raising a new Pull Request to take care of this new configuration feature.

We will take #39718 PR further as per our regular process.