Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional bool return type into PHPDoc information #35660

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Add additional bool return type into PHPDoc information #35660

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4c98fa
Add bool return type
Jun 22, 2022
877b766
Merge branch '2.4-develop' into issues/34598
engcom-Dash Sep 27, 2024
7290637
35660: Fix PHPCS visibility warning for constants
engcom-Dash Sep 30, 2024
96f55d0
Merge branch '2.4-develop' into issues/34598
engcom-Dash Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions lib/internal/Magento/Framework/DB/Adapter/AdapterInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,66 +16,66 @@
*/
interface AdapterInterface
{
const INDEX_TYPE_PRIMARY = 'primary';
public const INDEX_TYPE_PRIMARY = 'primary';

const INDEX_TYPE_UNIQUE = 'unique';
public const INDEX_TYPE_UNIQUE = 'unique';

const INDEX_TYPE_INDEX = 'index';
public const INDEX_TYPE_INDEX = 'index';

const INDEX_TYPE_FULLTEXT = 'fulltext';
public const INDEX_TYPE_FULLTEXT = 'fulltext';

const FK_ACTION_CASCADE = 'CASCADE';
public const FK_ACTION_CASCADE = 'CASCADE';

const FK_ACTION_SET_NULL = 'SET NULL';
public const FK_ACTION_SET_NULL = 'SET NULL';

const FK_ACTION_NO_ACTION = 'NO ACTION';
public const FK_ACTION_NO_ACTION = 'NO ACTION';

const FK_ACTION_RESTRICT = 'RESTRICT';
public const FK_ACTION_RESTRICT = 'RESTRICT';

const FK_ACTION_SET_DEFAULT = 'SET DEFAULT';
public const FK_ACTION_SET_DEFAULT = 'SET DEFAULT';

const INSERT_ON_DUPLICATE = 1;
public const INSERT_ON_DUPLICATE = 1;

const INSERT_IGNORE = 2;
public const INSERT_IGNORE = 2;

/** Strategy for updating data in table. See https://dev.mysql.com/doc/refman/5.7/en/replace.html */
const REPLACE = 4;
public const REPLACE = 4;

const ISO_DATE_FORMAT = 'yyyy-MM-dd';
public const ISO_DATE_FORMAT = 'yyyy-MM-dd';

const ISO_DATETIME_FORMAT = 'yyyy-MM-dd HH-mm-ss';
public const ISO_DATETIME_FORMAT = 'yyyy-MM-dd HH-mm-ss';

const INTERVAL_SECOND = 'SECOND';
public const INTERVAL_SECOND = 'SECOND';

const INTERVAL_MINUTE = 'MINUTES';
public const INTERVAL_MINUTE = 'MINUTES';

const INTERVAL_HOUR = 'HOURS';
public const INTERVAL_HOUR = 'HOURS';

const INTERVAL_DAY = 'DAYS';
public const INTERVAL_DAY = 'DAYS';

const INTERVAL_MONTH = 'MONTHS';
public const INTERVAL_MONTH = 'MONTHS';

const INTERVAL_YEAR = 'YEARS';
public const INTERVAL_YEAR = 'YEARS';

/**
* Error message for DDL query in transactions
*/
const ERROR_DDL_MESSAGE = 'DDL statements are not allowed in transactions';
public const ERROR_DDL_MESSAGE = 'DDL statements are not allowed in transactions';

/**
* Error message for unfinished rollBack transaction
*/
const ERROR_ROLLBACK_INCOMPLETE_MESSAGE = 'Rolled back transaction has not been completed correctly.';
public const ERROR_ROLLBACK_INCOMPLETE_MESSAGE = 'Rolled back transaction has not been completed correctly.';

/**
* Error message for asymmetric transaction rollback
*/
const ERROR_ASYMMETRIC_ROLLBACK_MESSAGE = 'Asymmetric transaction rollback.';
public const ERROR_ASYMMETRIC_ROLLBACK_MESSAGE = 'Asymmetric transaction rollback.';

/**
* Error message for asymmetric transaction commit
*/
const ERROR_ASYMMETRIC_COMMIT_MESSAGE = 'Asymmetric transaction commit.';
public const ERROR_ASYMMETRIC_COMMIT_MESSAGE = 'Asymmetric transaction commit.';

/**
* Begin new DB transaction for connection
Expand Down Expand Up @@ -598,7 +598,7 @@ public function fetchPairs($sql, $bind = []);
*
* @param string|\Magento\Framework\DB\Select $sql An SQL SELECT statement.
* @param mixed $bind Data to bind into SELECT placeholders.
* @return string
* @return string|bool
*/
public function fetchOne($sql, $bind = []);

Expand Down