Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#32679: setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment #33332

Open
wants to merge 11 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#32679: setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment #33332

wants to merge 11 commits into from

Conversation

4ctobias
Copy link
Contributor

  • Switched --dry-run-Parameter to VALUE_NONE in UpgradeCommand.php
  • Switched --dry-run-Parameter to VALUE_NONE in InstallCommand.php

Description (*)

setup:upgrade and setup:install does not require a value of true when using the --dry-run-parameter. This is now the same beaviour for a dry run as in other Linux-Tools (eg. rsync). As before this fix using --dry-run did not start a dry run for the command, the usage of --dry-run=true was required.

Fixed Issues (if relevant)

  1. Fixes setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment #32679

Manual testing scenarios (*)

  1. Change a module version
  2. Run setup:upgrade --dry-run
  3. The module version should not be upgraded in the setup_module-table

@4ctobias
magento#32679: setup:upgrade --dry-run does not work as expected by o…
9cbc69c 
…ther dry-run-commands in Linux-environment

- Switched --dry-run-Parameter to VALUE_NONE in UpgradeCommand.php
- Switched --dry-run-Parameter to VALUE_NONE in InstallCommand.php
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2021

Hi @4ctobias. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@4ctobias 4ctobias closed this Jun 24, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2021

Hi @4ctobias, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@4ctobias 4ctobias reopened this Jun 24, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev self-assigned this Jun 24, 2021
@ihor-sviziev ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jun 24, 2021
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix and removed Progress: review labels Jun 24, 2021
ihor-sviziev
ihor-sviziev requested changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix integration tests

@Den4ik Den4ik self-requested a review June 25, 2021 16:23
@Den4ik Den4ik self-assigned this Jun 25, 2021
4ctobias and others added 2 commits July 1, 2021 15:51
@4ctobias
magento#32679: setup:upgrade --dry-run does not work as expected by o…
93d1a50 
…ther dry-run-commands in Linux-environment

- Fixed test dry-run - now also arguments without value are supported
@4ctobias
Merge branch '2.4-develop' into fix-32679-dry-run
12b081a
@ihor-sviziev
Copy link
Contributor

@magento run all tests

4ctobias added 2 commits July 1, 2021 21:02
@4ctobias
magento#32679: setup:upgrade --dry-run does not work as expected by o…
878e480 
…ther dry-run-commands in Linux-environment

- Fixed cli-param-handling on tests for detecting parameters that should have no value - and discarding parameters that should removed for the test as no value was specified
@4ctobias
Merge branch 'fix-32679-dry-run' of https://github.com/4ctobias/magen…
e17c09a 
…to2-fork into fix-32679-dry-run
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jul 2, 2021
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9140 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9140 has been created to process this Pull Request

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Sep 2, 2021
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 22, 2023
@engcom-Dash engcom-Dash self-assigned this Oct 3, 2024
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 3, 2024 •
edited
Loading

Hello @4ctobias,

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop
Steps to reproduce

  • Create a module with schema patch.
  • Run bin/magento setup:upgrade --dry-run

Before: ✖️
DB schema is being changed.
After: ✔️
DB schema should not be changed

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Static Tests, Integration Tests, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Integration Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 17, 2024 •
edited
Loading

The functional B2B test failures are different with a known issue in the most recent two successive builds. Additionally, the static test and Integration Tests failure are a known issue; therefore, I am moving it to Merge in Progress.

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33332/3073062905aea28e955ef7361b882fdb/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/33a6fc63d80a2dc6/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33332/845319c70a7c4f7dca47ffa340c9b10f/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/19e97d5929846bad/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Setup Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment
6 participants
@4ctobias @ihor-sviziev @magento-engcom-team @engcom-Dash @Den4ik @engcom-Delta