Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest #31862

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

denchev
Copy link
Contributor

@denchev denchev commented Jan 27, 2021

Description (*)

While looking at functional tests provided by Magento I found that one of the tests AdminSetUpWatermarkForSwatchImageTest has two severity tags with the same value = MAJOR. I think only one of them is needed.

Related Pull Requests

I cannot find which pull request added the second one but the commit is bba6a43

The original commit that introduced the test and the first severity tag is 9bea49f

Fixed Issues (if relevant)

No issue is created for this ticket.

Manual testing scenarios (*)

No manual tests are required. This is code refactoring.

Questions or comments

No questions or comments at this point.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest #38504: Remove a duplicated tag from MFTF test AdminSetUpWatermarkForSwatchImageTest

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2021

Hi @denchev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev ihor-sviziev self-assigned this Jan 27, 2021
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Progress: review Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 27, 2021
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8708 has been created to process this Pull Request

@denchev
Copy link
Contributor Author

denchev commented Jan 27, 2021

@magento run all tests

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jan 28, 2021
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jan 29, 2021

@gabrieldagama @sidolov, can we quickly merge this PR? it fixes duplicated XML fields in MFTF tests. The risk of this PR is shallow.

@sidolov
Copy link
Contributor

sidolov commented Jan 29, 2021

Hi @ihor-sviziev! The fix does not affect test execution flow, so, the delivery may be postponed for a while since we still have a lot of PRs in high priority backlog.

@engcom-Delta
Copy link
Contributor

@magento create issue

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 10, 2024
@engcom-Dash engcom-Dash self-assigned this Oct 17, 2024
@engcom-Dash
Copy link
Contributor

Manual testing is not required since it removes duplicate variables from the file.

Builds are failed, so moving it to Extended Testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Swatches Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Release Line: 2.4 Risk: low Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest
8 participants