-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest #31862
base: 2.4-develop
Are you sure you want to change the base?
Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest #31862
Conversation
Hi @denchev. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @ihor-sviziev, thank you for the review. |
@magento run all tests |
@gabrieldagama @sidolov, can we quickly merge this PR? it fixes duplicated XML fields in MFTF tests. The risk of this PR is shallow. |
Hi @ihor-sviziev! The fix does not affect test execution flow, so, the delivery may be postponed for a while since we still have a lot of PRs in high priority backlog. |
@magento create issue |
Manual testing is not required since it removes duplicate variables from the file. Builds are failed, so moving it to Extended Testing. |
@magento run all tests |
@magento run Functional Tests B2B |
The Functional B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress. Functional Tests B2B Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31862/3d20cae159b7173af956c63361647061/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/5a833956448d3705/ |
Description (*)
While looking at functional tests provided by Magento I found that one of the tests AdminSetUpWatermarkForSwatchImageTest has two severity tags with the same value = MAJOR. I think only one of them is needed.
Related Pull Requests
I cannot find which pull request added the second one but the commit is bba6a43
The original commit that introduced the test and the first severity tag is 9bea49f
Fixed Issues (if relevant)
No issue is created for this ticket.
Manual testing scenarios (*)
No manual tests are required. This is code refactoring.
Questions or comments
No questions or comments at this point.
Contribution checklist (*)
Resolved issues: