Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Swatches Helper / Remove misleading aliases, refactor the class #31355

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Refactor: Swatches Helper / Remove misleading aliases, refactor the class #31355

merged 3 commits into from
Feb 23, 2023

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Dec 18, 2020 •
edited by m2-assistant bot
Loading

Description (*)

The Helper contains extremely misleading import aliases.
Some of the elements were refactored.

Related Pull Requests

Fixed Issues (if relevant)

  • [ x ] Misleading aliases

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Refactor: Swatches Helper / Remove misleading aliases, refactor the class #31373: Refactor: Swatches Helper / Remove misleading aliases, refactor the class

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@lbajsarowicz lbajsarowicz changed the title REFACTOR: Swatches Helper / Remove misleading aliases, refactor the class Refactor: Swatches Helper / Remove misleading aliases, refactor the class Dec 18, 2020
@ihor-sviziev ihor-sviziev self-assigned this Dec 19, 2020
@ihor-sviziev ihor-sviziev added Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 19, 2020
ihor-sviziev
ihor-sviziev approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes form this PR.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@ihor-sviziev
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 21, 2020
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8559 has been created to process this Pull Request

@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Dec 23, 2020
@ihor-sviziev ihor-sviziev mentioned this pull request Mar 30, 2021
Closed
16 tasks
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Feb 1, 2023
@engcom-Lima engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 9, 2023
@engcom-Charlie engcom-Charlie self-assigned this Feb 10, 2023
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@lbajsarowicz @ihor-sviziev,

Thank you for your collaboration & contribution!

✔️ QA Passed
Refactor of Swatches helper class has been done also misleading aliases have been removed.

Manual Scenario Steps

  1. Gone through the PR changes, tested Swatches module
  2. Created Swatch attribute and tested product listing, detail page

After: ✔️
image

There are some build failures hence moving to Extended Testing

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

Fixed the static test failures and they its working fine now.

Related to current failing functional B2B, CE and EE tests, these are not failing because of this PR changes or not part of this PR. Hence moving it further on Merge in Progress.

Functional B2B:
image

Functional CE:
image

Functional EE:
image

Thank you!

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit dfe1548 into magento:2.4-develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Swatches Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Project: Community Picked PRs upvoted by the community Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Refactor: Swatches Helper / Remove misleading aliases, refactor the class
8 participants
@lbajsarowicz @ihor-sviziev @magento-engcom-team @engcom-Charlie @sidolov @sinhaparul @engcom-Lima @magento-devops-reposync-svc