Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated variables from one of less files #31150

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Remove duplicated variables from one of less files #31150

wants to merge 4 commits into from

Conversation

lumnn
Copy link
Contributor

@lumnn lumnn commented Dec 3, 2020 •
edited by m2-assistant bot
Loading

Description (*)

PR removes 2 duplicated values from one of the less files.

Questions or comments

The removed code can also be found on lines 70, 71

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove duplicated variables from one of less files #31154: Remove duplicated variables from one of less files

@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2020

Hi @lumnn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Dec 3, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 3, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 3, 2020
Open
4 tasks
@ihor-sviziev ihor-sviziev self-assigned this Dec 3, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@mrtuvn
Copy link
Contributor

mrtuvn commented Dec 4, 2020

you have hawk eyes nice catch!

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Dec 4, 2020
ihor-sviziev
ihor-sviziev approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved!

Failing tests not related to changes from this PR

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8512 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-8512 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 10, 2024
@engcom-Dash engcom-Dash self-assigned this Oct 17, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Manual testing is not required since it removes duplicate variables from the file.

Builds are failed, so moving it to Extended Testing.

@engcom-Dash
Copy link
Contributor

Got the green build so moving it to merge in progress.

@hostep
Copy link
Contributor

hostep commented Oct 17, 2024

Before this gets merged, the first variable is indeed a duplicate definition, but the second one is not, unless I'm missing something, these don't match 100%:

line 71: @_pager-action-text-decoration-hover: @pager-action__hover__text-decoration,

vs

line 94: @_pager-action-text-decoration-hover: @pager-action__text-decoration,

The proposal in this PR is to remove the second one, which should cause a change in behavior, right? So I don't understand why we shouldn't test this change?

Manual testing is not required since it removes duplicate variables from the file.

@engcom-Dash
Copy link
Contributor

Before this gets merged, the first variable is indeed a duplicate definition, but the second one is not, unless I'm missing something, these don't match 100%:

line 71: @_pager-action-text-decoration-hover: @pager-action__hover__text-decoration,

vs

line 94: @_pager-action-text-decoration-hover: @pager-action__text-decoration,

The proposal in this PR is to remove the second one, which should cause a change in behavior, right? So I don't understand why we shouldn't test this change?

Manual testing is not required since it removes duplicate variables from the file.

Thanks, @hostep. I reviewed the codebase earlier but it seems I overlooked the line 94. I've now reverted the changes on line 94.

I’m moving it to Extended Testing again since I reverted the changes on line 94.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

Got the green build so moving it to merge in progress.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@ptylek ptylek ptylek approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@ptylek ptylek

@engcom-Dash engcom-Dash

Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Release Line: 2.4 Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Remove duplicated variables from one of less files
9 participants
@lumnn @sidolov @ihor-sviziev @mrtuvn @magento-engcom-team @engcom-Dash @hostep @ptylek @engcom-Bravo