Removed code redundancy for module frontend layouts. #30644

pratiksangani · 2020-10-24T16:41:20Z

Description (*)

Removed code redundancy to theme layouts for Magento_Msrp, Magento_LoginAsCustomerAssistance, Magento_Newsletter & Magento_Sitemap modules frontend layouts.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Removed code redundancy for module frontend layouts. #30673: Removed code redundancy for module frontend layouts.

…ginAsCustomerAssistance, Magento_Newsletter & Magento_Sitemap modules frontend layouts.

m2-assistant · 2020-10-24T16:41:23Z

Hi @pratiksangani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sidolov · 2020-10-27T19:23:47Z

@magento create issue

pratiksangani · 2020-10-29T18:56:14Z

@magento run all tests

pratiksangani · 2020-10-30T16:57:53Z

@sidolov Will you please proceed this PR?

ihor-sviziev · 2021-01-15T14:48:05Z

@magento run all tests

ihor-sviziev · 2021-01-18T07:37:33Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker

ihor-sviziev

✔ Approved.

Failing tests looks not related to changes form this PR.

magento-engcom-team · 2021-01-18T12:14:44Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8657 has been created to process this Pull Request

magento-engcom-team · 2021-01-18T12:14:46Z

@pratiksangani thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

magento-engcom-team · 2021-03-30T10:15:46Z

Hi @mrtuvn, thank you for the review.
ENGCOM-8657 has been created to process this Pull Request

engcom-Echo · 2024-03-20T07:44:33Z

@magento run all tests

engcom-Echo · 2024-03-22T03:38:33Z

@magento run all tests

engcom-Echo · 2024-03-26T04:04:29Z

@magento run all tests

engcom-November · 2024-06-18T08:04:59Z

@magento run Semantic Version Checker

engcom-November · 2024-06-18T09:37:45Z

@magento run all tests

engcom-November · 2024-06-20T05:46:41Z

@magento run all tests

engcom-November · 2024-06-20T07:10:21Z

As this is a code quality PR, manual testing is not applicable.

But since the builds are failed, moved it to Extended Testing.

engcom-November · 2024-06-21T05:43:36Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, WebAPI Tests

engcom-November · 2024-06-21T09:16:25Z

@magento run Integration Tests

engcom-November · 2024-06-21T11:09:56Z

The repeating failures for Functional Tests B2B, CE and EE are flaky and known issues.

Functional Tests B2B
Run 1:

Run 2:

Known issues:
ACQE-6648 - StorefrontUpdateCustomerAddressBelgiumTest
ACQE-6695 - TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
ACQE-6321 - StoreFrontAddOutOfStockProductToShoppingCartTest

Functional Tests CE
Run 1:

Run 2:

Known issues:
ACQE-5825 - OrderDataGridDisplaysPurchaseDateTest
ACQE-6695 - TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest

Functional Tests EE
Run 1:

Run 2:

Known issues:
ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest
ACQE-6695 - TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

engcom-November · 2024-06-21T11:14:14Z

The repeating WebAPI failure is flaky and known issue.

WebAPI Tests
Run 1:

Run 2:

Known issue:
ACP2E-3082 - testSendNegotiableQuoteCannotResend

Hence moving it to Merge in Progress.

engcom-Charlie · 2024-06-28T06:34:41Z

@magento run Integration Tests

engcom-Charlie · 2024-06-28T09:16:33Z

@magento run all tests

Removed code redundancy to theme layouts for Magento_Msrp, Magento_Lo…

e200706

…ginAsCustomerAssistance, Magento_Newsletter & Magento_Sitemap modules frontend layouts.

ghost added the Progress: pending review label Oct 24, 2020

magento-engcom-team added Area: Frontend Component: LoginAsCustomerAssistance Component: Msrp Component: Newsletter Component: Sitemap Release Line: 2.4 labels Oct 24, 2020

sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 27, 2020

m2-assistant bot mentioned this pull request Oct 27, 2020

[Issue] Removed code redundancy for module frontend layouts. #30673

Open

4 tasks

ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 15, 2021

ihor-sviziev self-assigned this Jan 15, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 15, 2021

ihor-sviziev approved these changes Jan 18, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Jan 18, 2021

ihor-sviziev mentioned this pull request Mar 30, 2021

Let's discuss approved PRs #32625

Closed

16 tasks

mrtuvn approved these changes Mar 30, 2021

View reviewed changes

m2-community-project bot assigned mrtuvn Mar 30, 2021

m2-community-project bot added Progress: extended testing and removed Progress: pending approval labels Mar 21, 2024

engcom-Echo and others added 2 commits March 22, 2024 09:02

Svc failure fix

9bad282

Fix SVC failure

42d33a4

Merge branch '2.4-develop' into hacktoberfest_PR_4

bc93cda

engcom-November and others added 2 commits June 18, 2024 13:30

svc fix

ad25d5b

Merge branch '2.4-develop' into hacktoberfest_PR_4

94d5b7e

engcom-November self-assigned this Jun 20, 2024

m2-community-project bot added Progress: ready for testing Progress: extended testing and removed Progress: extended testing Progress: ready for testing labels Jun 20, 2024

Merge branch '2.4-develop' into hacktoberfest_PR_4

e6f4149

Merge branch '2.4-develop' into hacktoberfest_PR_4

5511677

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jun 21, 2024

Merge branch '2.4-develop' into hacktoberfest_PR_4

ccff588

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed code redundancy for module frontend layouts. #30644

Removed code redundancy for module frontend layouts. #30644

pratiksangani commented Oct 24, 2020 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Oct 24, 2020

sidolov commented Oct 27, 2020

pratiksangani commented Oct 29, 2020

pratiksangani commented Oct 30, 2020

ihor-sviziev commented Jan 15, 2021

ihor-sviziev commented Jan 18, 2021

ihor-sviziev left a comment

magento-engcom-team commented Jan 18, 2021

magento-engcom-team commented Jan 18, 2021

magento-engcom-team commented Mar 30, 2021

engcom-Echo commented Mar 20, 2024

engcom-Echo commented Mar 22, 2024

engcom-Echo commented Mar 26, 2024

engcom-November commented Jun 18, 2024

engcom-November commented Jun 18, 2024

engcom-November commented Jun 20, 2024

engcom-November commented Jun 20, 2024

engcom-November commented Jun 21, 2024

engcom-November commented Jun 21, 2024

engcom-November commented Jun 21, 2024 •

edited

Loading

engcom-November commented Jun 21, 2024

engcom-Charlie commented Jun 28, 2024

engcom-Charlie commented Jun 28, 2024

Removed code redundancy for module frontend layouts. #30644

Are you sure you want to change the base?

Removed code redundancy for module frontend layouts. #30644

Conversation

pratiksangani commented Oct 24, 2020 • edited by m2-assistant bot Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Oct 24, 2020

sidolov commented Oct 27, 2020

pratiksangani commented Oct 29, 2020

pratiksangani commented Oct 30, 2020

ihor-sviziev commented Jan 15, 2021

ihor-sviziev commented Jan 18, 2021

ihor-sviziev left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Jan 18, 2021

magento-engcom-team commented Jan 18, 2021

magento-engcom-team commented Mar 30, 2021

engcom-Echo commented Mar 20, 2024

engcom-Echo commented Mar 22, 2024

engcom-Echo commented Mar 26, 2024

engcom-November commented Jun 18, 2024

engcom-November commented Jun 18, 2024

engcom-November commented Jun 20, 2024

engcom-November commented Jun 20, 2024

engcom-November commented Jun 21, 2024

engcom-November commented Jun 21, 2024

engcom-November commented Jun 21, 2024 • edited Loading

engcom-November commented Jun 21, 2024

engcom-Charlie commented Jun 28, 2024

engcom-Charlie commented Jun 28, 2024

pratiksangani commented Oct 24, 2020 •

edited by m2-assistant bot

Loading

engcom-November commented Jun 21, 2024 •

edited

Loading