Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout_index_index.xml file code improvement. #30538

Merged

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Oct 19, 2020

Description (*)

Removed sortOrder from messages, authentication, progressBar, estimation, and sidebar checkout components as they are already been rendered without those sortOrders and individual getRegions at app/code/Magento/Checkout/view/frontend/web/template/onepage.html

Related Pull Requests

Fixed Issues (if relevant)

  1. This is code improvement.

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] checkout_index_index.xml file code improvement. #30550: checkout_index_index.xml file code improvement.

…ion, and sidebar checkout components as they are already been rendered without those sortOrders and individual getRegions at app/code/Magento/Checkout/view/frontend/web/template/onepage.html
@m2-assistant
Copy link

m2-assistant bot commented Oct 19, 2020

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar
Copy link
Contributor

rogyar commented Oct 19, 2020

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento give me test instance

@magento-deployment-service
Copy link

Hi @lenaorobei. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 19, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 19, 2020

@magento create issue

@rogyar
Copy link
Contributor

rogyar commented Oct 21, 2020

@magento run Integration Tests

Copy link
Contributor

@ptylek ptylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it gives wrong impression that changing sortOrder could have any impact for changing those checkout components order. Adding Auto-Tests: Not Required label as removing these sortOrders doesn't change anything - components are displayed with getRegion().

@ghost ghost assigned ptylek Oct 22, 2020
@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 22, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-8370 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sanganinamrata
Copy link
Member Author

@ptylek, Will you please add hacktoberfest-accepted label to this PR? This event is about to finish. Without this label to my PR, I'll be eliminated from that challenge. :)

@ptylek
Copy link
Contributor

ptylek commented Oct 23, 2020

@sanganinamrata all approved/merged PRs should be counted for the hacktoberfest, afaik label is only added if they can't be approved/merged before the end of October

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

This is code improvement. The order of sorting components has not been changed.
Everything work as previously (expected).

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @sanganinamrata, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Checkout Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] checkout_index_index.xml file code improvement.
8 participants