-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkout_index_index.xml file code improvement. #30538
checkout_index_index.xml file code improvement. #30538
Conversation
…ion, and sidebar checkout components as they are already been rendered without those sortOrders and individual getRegions at app/code/Magento/Checkout/view/frontend/web/template/onepage.html
Hi @sanganinamrata. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento give me test instance |
Hi @lenaorobei. Thank you for your request. I'm working on Magento instance for you. |
Hi @lenaorobei, here is your Magento Instance: https://cdb368462778ff5928172ee147e93fbe.instances.magento-community.engineering |
@magento create issue |
@magento run Integration Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it gives wrong impression that changing sortOrder could have any impact for changing those checkout components order. Adding Auto-Tests: Not Required label as removing these sortOrders doesn't change anything - components are displayed with getRegion().
Hi @ptylek, thank you for the review.
|
@ptylek, Will you please add |
@sanganinamrata all approved/merged PRs should be counted for the hacktoberfest, afaik label is only added if they can't be approved/merged before the end of October |
✔️ QA Passed This is code improvement. The order of sorting components has not been changed. |
Hi @sanganinamrata, thank you for your contribution! |
Description (*)
Removed sortOrder from messages, authentication, progressBar, estimation, and sidebar checkout components as they are already been rendered without those sortOrders and individual getRegions at
app/code/Magento/Checkout/view/frontend/web/template/onepage.html
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
N/A
Contribution checklist (*)
Resolved issues: