Skip to content

Resolve New Order not sending if a comma is followed by a blank space in the 'Send Order Email Copy To' field issue25072 #25085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve New Order not sending if a comma is followed by a blank space in the 'Send Order Email Copy To' field #25072: New Order not sending if a comma is followed by a blank space in the 'Send Order Email Copy To' field

Fixed Issues (if relevant)

  1. New Order not sending if a comma is followed by a blank space in the 'Send Order Email Copy To' field #25072: New Order not sending if a comma is followed by a blank space in the 'Send Order Email Copy To' field

Manual testing scenarios (*)

  1. In the BO, go to Stores >> Configuration >> Sales >> Sales Emails
  2. Under Orders, in the 'Send Order Email Copy To' field, enter a list of emails in the following format: 'admin1@email.com, admin2@email.com' (note the blank space after the comma)

Expected result

  1. The New Order email should be sent to the customer and the two admins

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 16, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

… in the 'Send Order Email Copy To' field issue25072
@edenduong edenduong force-pushed the 2.3-bugfix/email_copy_with_space_issue25072 branch from bb7acc9 to e075022 Compare October 16, 2019 09:53
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 16, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 17, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 18, 2019
…a blank space in the 'Send Order Email Copy To' field issue25072 #25085
@magento-engcom-team magento-engcom-team merged commit 36174c6 into magento:2.3-develop Oct 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
@edenduong
Copy link
Contributor Author

Hi @VladimirZaets : Could I receive the Bugfix award for this PR ? Thank you very much ! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Order not sending if a comma is followed by a blank space in the 'Send Order Email Copy To' field
5 participants