Skip to content

Use attribute IDs when getting configurable child products if specified (#24483) #24875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 26, 2019

Conversation

lfolco
Copy link
Contributor

@lfolco lfolco commented Oct 5, 2019

Description (*)

The method \Magento\ConfigurableProduct\Model\Product\Type\Configurable::getUsedProducts() has an optional parameter, $requiredAttributeIds, that is supposed to add the given attribute IDs to the returned products. This parameter is ignored in the method body.

Fixed Issues (if relevant)

  1. Parameter $requiredAttributeIds of getUsedProducts() on configurable product type is not used, custom attribute loading does not work #24483: Parameter $requiredAttributeIds of getUsedProducts() on configurable product type is not used, custom attribute loading does not work

Manual testing scenarios (*)

None. I created two additional integration tests, \Magento\ConfigurableProduct\Model\Product\Type\ConfigurableTest::testGetUsedProductsWithRequiredAttributes and \Magento\ConfigurableProduct\Model\Product\Type\ConfigurableTest::testGetUsedProductsWithoutRequiredAttributes

Questions or comments

None

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lfolco lfolco requested a review from akaplya as a code owner October 5, 2019 21:56
@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2019

Hi @lfolco. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lfolco lfolco changed the title Use attribute IDs when getting used products if specified (#24483) Use attribute IDs when getting configurable child products if specified (#24483) Oct 5, 2019
@kalpmehta kalpmehta self-assigned this Oct 5, 2019
@kalpmehta kalpmehta added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6015 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 15, 2019
@magento-engcom-team magento-engcom-team merged commit f4cbd32 into magento:2.3-develop Oct 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2019

Hi @lfolco, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@convenient
Copy link
Contributor

I just tried to use this logic today and was surprised to see this bug. thanks for the PR @lfolco

@lfolco lfolco deleted the configproducts branch March 14, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants