-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Use attribute IDs when getting configurable child products if specified (#24483) #24875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use attribute IDs when getting configurable child products if specified (#24483) #24875
Conversation
Merging upstream
Hi @lfolco. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @kalpmehta, thank you for the review. |
✔️ QA passed |
Hi @lfolco, thank you for your contribution! |
I just tried to use this logic today and was surprised to see this bug. thanks for the PR @lfolco |
Description (*)
The method
\Magento\ConfigurableProduct\Model\Product\Type\Configurable::getUsedProducts()
has an optional parameter,$requiredAttributeIds
, that is supposed to add the given attribute IDs to the returned products. This parameter is ignored in the method body.Fixed Issues (if relevant)
Manual testing scenarios (*)
None. I created two additional integration tests,
\Magento\ConfigurableProduct\Model\Product\Type\ConfigurableTest::testGetUsedProductsWithRequiredAttributes
and\Magento\ConfigurableProduct\Model\Product\Type\ConfigurableTest::testGetUsedProductsWithoutRequiredAttributes
Questions or comments
None
Contribution checklist (*)