Skip to content

Fixed downloadable selected links price not added to product main price on cart configure page. #24579 #24580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2019
Merged

Fixed downloadable selected links price not added to product main price on cart configure page. #24579 #24580

merged 2 commits into from
Sep 20, 2019

Conversation

rani-priya
Copy link
Contributor

Fixed downloadable selected links price not added to product main price on cart configure page. #24579

Description (*)

Fixed Issues (if relevant)

  1. Downloadable selected links price not added to product main price on cart configure page. #24579: downloadable selected links price not added to product main price on cart configure page.

Manual testing scenarios (*)

  1. Create a downloadable product with some downloadable links
  2. Select link and add to cart
  3. edit that product from cart

Questions or comments

downloadable

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@rani-priya rani-priya requested a review from DrewML as a code owner September 13, 2019 04:57
@m2-assistant
Copy link

m2-assistant bot commented Sep 13, 2019

Hi @rani-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

ihor-sviziev
ihor-sviziev requested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rani-webkul,
Please review my comment related to jquery ui change.

Also commit author's email is not related to your GitHub account (you can check that by clicking on icon near commit message, it should be clickable). Could you fix that by adding email to your github account OR changing commit author email & force push?

app/code/Magento/Downloadable/view/frontend/web/js/downloadable.js Outdated
@@ -7,7 +7,7 @@
*/
define([
'jquery',
'jquery-ui-modules/widget',
'jquery/ui',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you changed this line?
It was changed to jquery-ui-modules/widget in order to make split jquery UI to separate modules. I believe it's not related to the fix. If so - please revert this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Actually it was by mistake.

@ghost ghost assigned ihor-sviziev Sep 13, 2019
@ihor-sviziev
Copy link
Contributor

@rani-webkul author email still not related to your github account on 1st commit.
https://github.com/magento/magento2/pull/24580/commits
image
Please fix that

@rani-priya
Copy link
Contributor Author

@ihor-sviziev done

@ihor-sviziev
Copy link
Contributor

Hi @rani-webkul, unfortunately commit still not related to your github account 😢

@rani-priya
Copy link
Contributor Author

rani-priya commented Sep 13, 2019 •
edited
Loading

Hi @ihor-sviziev, Could you please let me know how I can fix this issue?
I'm facing this issue from initial days, and it's due to I had changed my username.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 13, 2019 •
edited
Loading

@rani-webkul, please check your email in git config --global user.email. Looks like there is typo, there is no @ symbol.
To change it execute following command git config --global user.email your@email.com where your@email.com - your email linked to GitHub account.

Just after change commit author and force push your changes

@rani-priya
Copy link
Contributor Author

Hi @ihor-sviziev, Thank you.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5837 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Sep 16, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 16, 2019
@rani-priya rani-priya requested a review from akaplya as a code owner September 16, 2019 13:40
@engcom-Foxtrot engcom-Foxtrot added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Sep 17, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Sep 20, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Sep 20, 2019
@sidolov
ENGCOM-5837: Fixed downloadable selected links price not added to pro…
3d80c9a 
…duct main price on cart configure page. #24579 #24580
@magento-engcom-team magento-engcom-team merged commit 2f6332c into magento:2.3-develop Sep 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 20, 2019

Hi @rani-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@DrewML DrewML Awaiting requested review from DrewML

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Downloadable Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@rani-priya @ihor-sviziev @magento-engcom-team @engcom-Delta @engcom-Foxtrot