Skip to content

[Forwardport] Update time12h javascript validation rule to be compatible with js minify #17688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Aug 19, 2018

Original PR: #17652

Update time12h javascript validation rule to be compatible with js minify

Description

The space in the validation rule causes this rule to not work correctly when js minify is enabled, as it strips the space out of the validation rule regex.

Fixed Issues (if relevant)

  1. UI validation rule for valid time am/pm doesn't work when js is minified #17648: UI validation rule for valid time am/pm doesn't work when js is minified

Manual testing scenarios

  1. Validation rule with space doesn't work if js minify is enabled

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar August 19, 2018 07:22
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Ui Release Line: 2.3 labels Aug 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch changed the title [Frowardport] Update time12h javascript validation rule to be compatible with js minify [Forwardport] Update time12h javascript validation rule to be compatible with js minify Aug 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2824 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants