Skip to content

Fix #17579 Typo in Gallery.php #17659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

Spaggel
Copy link

@Spaggel Spaggel commented Aug 17, 2018

Description

This PR fixes a typo in Gallery.php, setMegiaGallery should be setMediaGallery.

Fixed issue

see #17579

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Spaggel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2816 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Spaggel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@Spaggel
Copy link
Author

Spaggel commented Aug 17, 2018

@magento-engcom-team Done! Question: can you add me to the partner-guapa developer list so the partner-contribution labels get added? Thanks!

@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2018

Hi @Spaggel , please, contact engcom@magento.com with your corporate email and we will add your account to the team.
Thank you!

@Spaggel
Copy link
Author

Spaggel commented Aug 17, 2018

@sidolov I accidentally pushed another commit to the same branch, I was going to open a new PR for it.. how should we proceed?

@Spaggel Spaggel added Partner: Guapa partners-contribution Pull Request is created by Magento Partner labels Aug 17, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 19, 2018

Hi @Spaggel , just reset to the first commit and force push the branch and we will proceed with current PR

@Spaggel
Copy link
Author

Spaggel commented Aug 19, 2018

@sidolov done

@magento-engcom-team
Copy link
Contributor

Hi @Spaggel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants