Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix for #15041 Adding a new fieldset to the admin category editor changes the position of the 'General' fieldset #17604

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Aug 14, 2018

Original Pull Request

#17540

Description

When a custom fieldset is added to the admin category editor, the General section (the one with "Enable category", "Include in Menu" and "Category Name") moves to the last position of the form.
Full description in #15041

Fixed Issues (if relevant)

  1. Adding a new fieldset to the admin category editor changes the position of the 'General' fieldset. #15041
    image

Manual testing scenarios

Provided in #15041

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Without the default sort order this fieldset goes to the very bottom after custom fieldset is added to the form
@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@jignesh-baldha jignesh-baldha deleted the 2.3-develop-PR-port-17540 branch August 27, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants