Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Refactor: remove some code duplication #17571

Merged
merged 1 commit into from
Aug 16, 2018
Merged

[Forwardport] Refactor: remove some code duplication #17571

merged 1 commit into from
Aug 16, 2018

Conversation

arnoudhgz
Copy link
Contributor

Original Pull Request

#17505

  • Complex statement that was executed three times moved to separate
    method so the logic is only on one place
  • The calculation for the index of the last record moved to a variable
    so the calculation is only being done once. This also reduces the amount
    of times this.getChildItems() is being called.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

+ Complex statement that was executed three times moved to separate
method so the logic is only on one place
+ The calculation for the index of the last record moved to a variable
so the calculation is only being done once. This also reduces the amount
of times `this.getChildItems()` is being called.
@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner labels Aug 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Ui Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants